8000 Possibility to not have eslint dependency? · Issue #156 · jhnns/rewire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Possibility to not have eslint dependency? #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you accou 8000 nt related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kareha opened this issue Jan 18, 2019 · 5 comments
Open

Possibility to not have eslint dependency? #156

kareha opened this issue Jan 18, 2019 · 5 comments

Comments

@kareha
Copy link
kareha commented Jan 18, 2019

I would like to have a clean environment and therefor less dependencies.

Eslint unfortunately has to many dependencies itself. So I would like to avoid it at all.
Is it possible you rewrite your module without dependencies?

If not: Does anybody know an alternative to rewire?
@artyomsv
Copy link

Hi, I'm also interested in this topic. I would prefer not to haves eslint shipped by the rewire library.

@xmedeko
Copy link
xmedeko commented May 27, 2021 •
edited
Loading

eslint is used in the code, see #143 (comment)

@amimas
Copy link
amimas commented Nov 26, 2021

Hello - any update available on this topic? Is there any alternative so that rewire doesn't need to rely on eslint during runtime?

@jhnns
Copy link
Owner
jhnns commented Dec 19, 2021

Since rewire will change const to let, we need to make sure that const variables are not re-assigned. Otherwise your test might work while your production code doesn't. This is done by using static analysis. I'm happy to replace ESLint if you know a better way to check that const variables aren't re-assigned :)

@uiolee
Copy link
uiolee commented Feb 2, 2024

Consider setting eslint as peerdependencies.

If the user has eslint installed in their project, pnpm will point to the same eslint for them.
But I don’t know how npm or yarn will deal with peerdependencies.

https://docs.npmjs.com/cli/v10/configuring-npm/package-json#peerdependencies
https://docs.npmjs.com/cli/v10/configuring-npm/package-json#peerdependenciesmeta

@zabil zabil mentioned this issue Aug 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
< 371D form data-target="create-branch.developmentForm" data-turbo="false" class="js-issue-sidebar-form" aria-label="Link issues" action="/jhnns/rewire/issues/closing_references?source_id=400706622&source_type=ISSUE" accept-charset="UTF-8" method="post">
Development

No branches or pull requests
6 participants
@jhnns @xmedeko @artyomsv @kareha @amimas @uiolee
0