8000 Do not assume `ItemInterface` is a collection by extending traversable `ItemListInterface` · Issue #50 · jkphl/micrometa · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Do not assume ItemInterface is a collection by extending traversable ItemListInterface #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rvanlaak opened this issue Dec 10, 2019 · 0 comments · Fixed by #66
Closed

Do not assume ItemInterface is a collection by extending traversable ItemListInterface #50

rvanlaak opened this issue Dec 10, 2019 · 0 comments · Fixed by #66

Comments

@rvanlaak
Copy link
Collaborator

The latest version of PHPStan does check for generics. In other words, for traversables it also does static code detection of their items.

The ItemInterface does extend ItemListInterface and thereby is a traversable. This is incorrect because it also can be a single item.

What is needed / what would conflict when removing the item interface from extending the list interface?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@rvanlaak
0