8000 Issue with Requires.private in pkgconfig file · Issue #21 · jrmadsen/PTL · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Issue with Requires.private in pkgconfig file #21
Closed
@badshah400

Description

@badshah400

Describe the bug
The Requires.private line in the pkgconfig file seems to be erroneous according to the pkg-config specifications. Both Requires and Requires.private should list names of pkg-config modules and not refer to flags directly, whereas -pthread looks more appropriate for Libs.private. Indeed on my system (openSUSE Tumbleweed) there does not seem to be any pkg-config module by the name of -pthread (or even pthread) installed even though PTL can find pthread.h when building and link against it just fine (glibc-devel provides the pthread header).

Please let me know if I am wrong here; if not, here is a straightforward patch which I can make a PR with if you wish:

Index: PTL-2.2.0/cmake/Templates/ptl.pc.in
===================================================================
--- PTL-2.2.0.orig/cmake/Templates/ptl.pc.in
+++ PTL-2.2.0/cmake/Templates/ptl.pc.in
@@ -6,6 +6,6 @@ Name: PTL
 Description: Parallel Tasking Library for C++
 Version: @PTL_VERSION_STRING@
 Requires: @PTL_PC_TBB_REQUIREMENT@
-Requires.private: -pthread
 Libs: -L${libdir} -lptl
+Libs.private: -pthread
 CFlags: -std=c++@CMAKE_CXX_STANDARD@ -pthread -I${includedir}

Many thanks for your library btw.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0