8000 Possible NPE in ThreadContext:getPartialTrace() found by SAST · Issue #8809 · jruby/jruby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Possible NPE in ThreadContext:getPartialTrace() found by SAST #8809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ngr-ilmarh opened this issue Apr 29, 2025 · 1 comment
Open

Possible NPE in ThreadContext:getPartialTrace() found by SAST #8809

ngr-ilmarh opened this issue Apr 29, 2025 · 1 comment
Milestone
JRuby 9.4.13.0

Comments

@ngr-ilmarh
Copy link

Our SAST shows possible NullPointerException in https://github.com/jruby/jruby/blob/master/core/src/main/java/org/jruby/runtime/ThreadContext.java#L937

    private RubyStackTraceElement[] getPartialTrace(int level, Integer length, Stream<StackWalker.StackFrame> stackStream) {
        if (length != null && length == 0) return RubyStackTraceElement.EMPTY_ARRAY;
        return TraceType.Gather.CALLER.getBacktraceData(this, stackStream).getPartialBacktrace(runtime, level + length);
    }

If length can be null, then it will cause NPE at level + length

Environment Information

We are analyzing versions 9.4.x (8-12), but this problem is still in master

Expected Behavior

  • No NPE at all. But it seems nobody catch it through the years, so i don't know if this Integer may hold null at all

Actual Behavior

  • have no tests to show this NPE, can't figure out how to make one. This is simply code analysis, that showed possible NPE
@ngr-ilmarh ngr-ilmarh mentioned this issue Apr 29, 2025
Open
@ngr-ilmarh
Copy link
Author

I've made a quick refactoring, hope it's ok

@headius headius added this to the JRuby 9.4.13.0 milestone Apr 30, 2025
@ngr-ilmarh ngr-ilmarh mentioned this issue May 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.4.13.0
Development

No branches or pull requests
2 participants
@headius @ngr-ilmarh
0