8000 Possible NPE in StartupInterpreterEngine:InterpreterEngine() found by SAST · Issue #8815 · jruby/jruby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Possible NPE in StartupInterpreterEngine:InterpreterEngine() found by SAST #8815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ngr-ilmarh opened this issue Apr 30, 2025 · 2 comments
Open

Possible NPE in StartupInterpreterEngine:InterpreterEngine() found by SAST #8815

ngr-ilmarh opened this issue Apr 30, 2025 · 2 comments

Comments

@ngr-ilmarh
Copy link

Our SAST shows possible NullPointerException

jruby/core/src/main/java/org/jruby/ir/interpreter/StartupInterpreterEngine.java

Line 51 in 0e43a52

Interpreter.LOG.info("I: " + ipc + ", R: " + rescuePCs[ipc] + " - " + instr + ">");
or redundant null check in

jruby/core/src/main/java/org/jruby/ir/interpreter/StartupInterpreterEngine.java

Line 106 in 0e43a52

ipc = rescuePCs == null ? -1 : rescuePCs[ipc]; 

public class StartupInterpreterEngine extends InterpreterEngine {
    public IRubyObject interpret(ThreadContext context, Block block, IRubyObject self,
                                 InterpreterContext interpreterContext, RubyModule implClass,
                                 String name, IRubyObject[] args, Block blockArg) {

...
        int[] rescuePCs = interpreterContext.getRescueIPCs();
...
        while (ipc < n) {
            Instr instr = instrs[ipc];

            Operation operation = instr.getOperation();
            if (debug) {
                Interpreter.LOG.info("I: " + ipc + ", R: "  + rescuePCs[ipc] + " - " + instr + ">");
                Interpreter.interpInstrsCount++;
            } else if (profile) {
                Profiler.instrTick(operation);
                Interpreter.interpInstrsCount++;
            }

            try {
...
            } catch (Throwable t) {
                if (debug) extractToMethodToAvoidC2Crash(instr, t);

                ipc = rescuePCs == null ? -1 : rescuePCs[ipc];

                if (debug) {
                    Interpreter.LOG.info("in : " + interpreterContext.getScope() + ", caught Java throwable: " + t + "; excepting instr: " + instr);
                    Interpreter.LOG.info("ipc for rescuer: " + ipc);
                }

                if (ipc == -1) {
                    Helpers.throwException(t);
                } else {
                    exception = t;
                }
            }
        }
...

If rescuePCs can be null, then NPE will be thrown, if rescuePCs can't be null, then null comparison is redundant.

Environment Information

We are analyzing versions 9.4.x (8-12), but this problem is still in master

Expected Behavior

  • No NPE at all. But it seems nobody catch it through the years, so i don't know if rescuePCs can be null at all

Actual Behavior

  • have no tests to show this NPE, can't figure out how to make one. This is simply code analysis, that showed possible NPE
@ngr-ilmarh
Copy link
Author

This issue is similar to #8814

@ngr-ilmarh ngr-ilmarh mentioned this issue Apr 30, 2025
Open
@headius
Copy link
Member
headius commented Apr 30, 2025

See comment in #8814.

@ngr-ilmarh ngr-ilmarh mentioned this issue May 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@headius @ngr-ilmarh
0