feat: add resources to logs collector daemonset for k8s api server access #2663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
commented
Feb 28, 2025
...tes/kubernetes_kurtosis_backend/logs_collector_functions/implementations/fluentbit/consts.go
Show resolved
Hide resolved
mieubrisse
approved these changes
Mar 11, 2025
...ckend_impls/docker/docker_kurtosis_backend/logs_collector_functions/logs_collector_labels.go
Show resolved
Hide resolved
...ls/kubernetes/kubernetes_kurtosis_backend/logs_collector_functions/destroy_logs_collector.go
Outdated
Show resolved
Hide resolved
...tes/kubernetes_kurtosis_backend/logs_collector_functions/implementations/fluentbit/consts.go
Outdated
Show resolved
Hide resolved
...end/logs_collector_functions/implementations/fluentbit/fluentbit_logs_collector_daemonset.go
Show resolved
Hide resolved
...end/logs_collector_functions/implementations/fluentbit/fluentbit_logs_collector_daemonset.go
Show resolved
Hide resolved
container-engine-lib/lib/backend_impls/kubernetes/kubernetes_manager/kubernetes_manager.go
Show resolved
Hide resolved
...ib/backend_impls/kubernetes/object_attributes_provider/enclave_object_attributes_provider.go
Outdated
Show resolved
Hide resolved
...ib/backend_impls/kubernetes/object_attributes_provider/enclave_object_attributes_provider.go
Outdated
Show resolved
Hide resolved
...backend_impls/kubernetes/object_attributes_provider/kubernetes_label_key/label_key_consts.go
Outdated
Show resolved
Hide resolved
...backend_impls/kubernetes/object_attributes_provider/kubernetes_label_key/label_key_consts.go
Outdated
Show resolved
Hide resolved
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
## Description
This PR adds a vector logs aggregator to the kubernetes backend and has
it output logs to a shared volume, mouned to the engine pod.
Additionally, it migrates the k8s backend to use the
`PersistentVolumeLogsDatabaseClient` so now both Docker and K8s are
streaming from a persistent volume containing logs aggregated by Vector.
To use kubernetes logging, users will need to use the v4 config and
specify the engine node they'd like the engine to be placed on. Both the
aggregator and engine will be placed on this node every `kurtosis engine
start` so the engine has access to the same logs db.
```
config-version: 4
should-send-metrics: true
kurtosis-clusters:
...
minikube:
type: "kubernetes"
config:
kubernetes-cluster-name: "minikube"
enclave-size-in-megabytes: 10
storage-class: "standard"
engine-node-name: "minikube-m02"
...
```
## Is this change user facing?
YES
## References
#2653
#2663
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 20, 2025
🤖 I have created a release *beep* *boop* --- ## [1.6.0](1.5.0...1.6.0) (2025-03-18) ### Features * add resources to logs collector daemonset for k8s api server access ([#2663](#2663)) ([5ae473c](5ae473c)) * export service logs (Docker) ([#2668](#2668)) ([1651249](1651249)) * fluent bit logs collector in k8s backend ([#2653](#2653)) ([05e3813](05e3813)) * vector logs aggregator in k8s ([#2669](#2669)) ([106e4a2](106e4a2)) ### Bug Fixes * exit codes on tasks ([#2654](#2654)) ([ffd86b8](ffd86b8)) * push ci docs ([#2680](#2680)) ([61857f0](61857f0)) * stdout for file inspect ([#2658](#2658)) ([6ae51a3](6ae51a3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The vector logs aggregator needs labels such as
enclave_uuid,service_uuid, etc. to write logs out to the proper filepaths. To enrich the log stream with these labels, the fluentbit logs collector uses thekubernetesfilter: https://docs.fluentbit.io/manual/pipeline/filters/kubernetes. The filter works by having the logs collector query the k8s api server for necessary information (pods labels in this case) about each pod. To query the api server, the logs collector needs perms.This change adds those perms in the form of a
ServiceAccountgiven aClusterRolewith acess via aClusterRoleBinding.Is this change user facing?
NO
References
#2653