8000 Comments about building, test and installation · Issue #168 · kahypar/kahypar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Comments about building, test and installation # 8000 168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MoiseRousseau opened this issue Jun 19, 2023 · 1 comment
Open

Comments about building, test and installation #168

MoiseRousseau opened this issue Jun 19, 2023 · 1 comment

Comments

@MoiseRousseau
Copy link

Hi,

I would like to report some difficulties I had for installing KaHyPar on Digital Research Alliance of Canada clusters as a module using EasyBuild:

  1. GoogleTest and PyBind11 were already installed on our clusters and I had to manually modify the corresponding CMakeLists.txt to find it. Maybe it would be interesting to first found these packages on the system and if not, use those provided in the external_tools folder. Something such as:
find_package(GTest)
if (not GTest_FOUND)
  add_subdirectory(external_tools/googletest EXCLUDE_FROM_ALL)
  include_directories(SYSTEM ${gtest_SOURCE_DIR}/include ${gtest_SOURCE_DIR})
  include_directories(SYSTEM ${gtest_SOURCE_DIR}/../googlemock/include ${gtest_SOURCE_DIR}/../googlemock/)
endif()
  1. Configuration files for tests are hard-codded. Therefore, if the build directory is not in the extracted KaHyPar folder (such as when build with EasyBuild), tests are failing. Maybe move the configuration files in the test directory ?
  2. The make install step does not copy the Python binding library. Maybe this can be copied in /usr/lib/python3/dist-packages ?

Moise
@SebastianSchlag
Copy link
Member

Hi Moise,

Thank you very much for your feedback.

Hi,

I would like to report some difficulties I had for installing KaHyPar on Digital Research Alliance of Canada clusters as a module using EasyBuild:

  1. GoogleTest and PyBind11 were already installed on our clusters and I had to manually modify the corresponding CMakeLists.txt to find it. Maybe it would be interesting to first found these packages on the system and if not, use those provided in the external_tools folder. Something such as:
find_package(GTest)
if (not GTest_FOUND)
  add_subdirectory(external_tools/googletest EXCLUDE_FROM_ALL)
  include_directories(SYSTEM ${gtest_SOURCE_DIR}/include ${gtest_SOURCE_DIR})
  include_directories(SYSTEM ${gtest_SOURCE_DIR}/../googlemock/include ${gtest_SOURCE_DIR}/../googlemock/)
endif()

This is a good idea and I think this should be doable.

  1. Configuration files for tests are hard-codded. Therefore, if the build directory is not in the extracted KaHyPar folder (such as when build with EasyBuild), tests are failing. Maybe move the configuration files in the test directory ?

We could try to symlink them. Copying them into the test directory does not seem like a good idea as it would increase the maintenance overhead.

  1. The make install step does not copy the Python binding library. Maybe this can be copied in /usr/lib/python3/dist-packages ?

This was actually done intentionally, because we don't know upfront to which dist-packages the user wants the file to be copied.

Moise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SebastianSchlag @MoiseRousseau
0