8000 test container location · Issue #44 · kdabir/has · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
test container location #44
Open
Open
@sdolenc

Description

@sdolenc

Thank you for merging #43 which gets us closer to testing every package has supports. I'll aim to submit pull requests that get us even closer to 100% in the future.

The Github Actions tests are currently using containers built from my fork of has, but it would be better if we built the containers using this official fork https://github.com/kdabir/has . That way future changes to the official dockerfiles would update the containers we use for testing.

If that sounds okay to you then could you please

  1. Sign in to https://hub.docker.com/ to create a new testing-has repository
  2. Build the four dockerfiles using settings similar to these
    image
  3. Then (after successful builds) updating Github Actions to use the official images instead of the "sdolenc" ones
    container: sdolenc/testing-has:${{ matrix.container }}
    and
    container: sdolenc/testing-has:${{ matrix.container }}

If it helps: I've added you as a collaborator for my repository on https://hub.docker.com

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0