Open
Description
Hey, I've opened a few PRs against this repo because we intend to use it in the future in objc (see SSheldon/ru
5253
st-objc#72), and in my fork of that project.
So, I have a few questions regarding the code:
- Have you considered whether the unstable
#[may_dangle]is appropriate forMBox? - It is generally a good idea to add
#[inline]on smaller functions, especially on forwarding implementations, have you considered this? - The file structure is a bit unorthodox compared to most rust projects (mostly that test functions live outside a
#[cfg(test)] mod tests) - would you be open to PRs refactoring this?
And a few regarding the project itself:
- Would you be open to relicensing under a dual MIT / Apache 2.0 license?
- This crate is currently lacking the high quality documentation that
c_vechas, especially regarding examples; maybe consider making some of the tests as documentation examples? - If you want more widespread adoption (which I generally think this crate deserves), maybe consider opening a PR against
sdl2andhyperscan.
Metadata
Metadata
Assignees
Labels
No labels