8000 Unrelated Types. SAST · Issue #40027 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Unrelated Types. SAST #40027
New issue
New issue
Closed
#40143
Closed
Unrelated Types. SAST#40027
#40143
Labels
kind/enhancementCategorizes a PR related to an enhancementrelease/26.3.0
@Anchels

Description

@Anchels
Anchels
opened on May 28, 2025

Description

This call to a generic collection method contains an argument with an incompatible class from that of the collection's parameter.

Discussion

No response

Motivation

Code clarity and consistency

Details

The method removeAssertion is attempting to remove an AttributeType object from a list of AssertionType objects:

keycloak/saml-core-api/src/main/java/org/keycloak/dom/saml/v2/mdattr/EntityAttributes.java

Lines 57 to 59 in 9e7ef79

public void removeAssertion(AttributeType attributeType) {
assertion.remove(attributeType);
}

Additionally, consider adjusting the variable names for both the addAssertion and removeAssertion methods to avoid obfuscation.

keycloak/saml-core-api/src/main/java/org/keycloak/dom/saml/v2/mdattr/EntityAttributes.java

Lines 53 to 59 in 9e7ef79

public void addAssertion(AssertionType attributeType) {
assertion.add(attributeType);
}
public void removeAssertion(AttributeType attributeType) {
assertion.remove(attributeType);
}

Found by Linux Verification Center with SVACE

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/enhancementCategorizes a PR related to an enhancementrelease/26.3.0

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0