Description
Before reporting an issue
- I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.
Area
token-exchange
Describe the bug
Since 3aac1eb4 there are two exactly same test methods in the KcOidcBrokerTokenExchangeTest . Methods are:
testExternalInternalTokenExchange()testExternalInternalTokenExchangeUsingIssuer()
Was it testExternalInternalTokenExchangeUsingIssuer() updated by accident?
It looks that either the testExternalInternalTokenExchangeUsingIssuer() should be updated as it was before or test should be removed if it i problematic. To me, it would makes sense to update it as it was before (at least it seems that it works when I've updated it back, but I may be missing something....)
Using issuer instead of IDP-alias is something, which we support in the external-internal token exchange and hence makes sense to have it tested (See AbstractTokenExchangeProvider.locateExchangeExternalTokenByAlias )
Version
nightly (from 2025-05-30)
Regression
- The issue is a regression
Expected behavior
Test for the scenario with external-internal token exchange when parameter subject_issuer references IDP issuer instead of IDP alias
Actual behavior
Test testExternalInternalTokenExchangeUsingIssuer() is testing alias and tests exactly the same as testExternalInternalTokenExchange()
How to Reproduce?
See above
Anything else?
No response