8000 Make `ProviderConfigurationBuilder` fail when a duplicate property is added. · Issue #40233 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Make ProviderConfigurationBuilder fail when a duplicate property is added. #40233
Closed
@RutgerLubbers

Description

@RutgerLubbers

Description

There was an issue with a duplicate configuration property used in the Argon2PasswordHashProviderFactory, see #40195. This can be made more robust, as requested in this comment: #40195 (comment) .

Now provider factories can register multiple configuration properties with the same name.

Discussion

No response

Motivation

The configuration, or the documentation of the configuration, can be wrong. This prevents duplicate keys to be documented for different purposes.

Details

Proposal is to let the call to ProviderFactory#getConfigMetadata() fail when a duplicate ProviderConfigProperty is added.

In the ProviderConfigurationBuilder I want to add a check to make sure that a ProviderConfigProperty's name is unique. I want to check the names using a simple set of strings.

The builder will throw a new, to be created, exception ProvicerConfigPropertyNameNotUniqueException which extends from ModelException.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0