8000 Potential copy-paste issue in PersistentClientSessionEntity.java · Issue #40663 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Potential copy-paste issue in PersistentClientSessionEntity.java #40663
New issue
New issue
Closed
#40676
Closed
Potential copy-paste issue in PersistentClientSessionEntity.java#40663
#40676
Assignees
ahus1
Labels
area/storageIndicates an issue that touches storage (change in data layout or data manipulation)kind/bugCategorizes a PR related to a bugrelease/26.2.6release/26.3.0team/core-shared
@leeriorio

Description

@leeriorio
leeriorio
opened on Jun 23, 2025

Description

I have identified a potential issue in the equals() method in the following code:

keycloak/model/jpa/src/main/java/org/keycloak/models/jpa/session/PersistentClientSessionEntity.java

Lines 196 to 197 in f4d5fa6

if (this.externalClientId != null ? !this.externalClientId.equals(key.clientId) : key.externalClientId != null) return false;
if (this.clientStorageProvider != null ? !this.clientStorageProvider.equals(key.clientId) : key.clientStorageProvider != null) return false;

It appears that the instance's fields should be compared to the corresponding fields of passed object, rather than comparing them to key.clientId

Discussion

No response

Motivation

No response

Details

No response

Found by Linux Verification Center with SVACE

Metadata

Metadata

Assignees

Labels

area/storageIndicates an issue that touches storage (change in data layout or data manipulation)kind/bugCategorizes a PR related to a bugrelease/26.2.6release/26.3.0team/core-shared

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions
    0