8000 Fix memory leaks · Issue #4 · kiedtl/finwe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix memory leaks #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service an 8000 d privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kiedtl opened this issue Feb 14, 2024 · 2 comments
Open

Fix memory leaks #4

kiedtl opened this issue Feb 14, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@kiedtl
Copy link
Owner
kiedtl commented Feb 14, 2024 •
edited
Loading

Currently, basically no memory is ever freed. The allocator isn't even deinit'd.

Start out by writing routines for recursively freeing ASTNode's, then start deinit'ing the GPA, and piping the output traces through less to find out what else is not being deallocated.
@kiedtl kiedtl added the bug Something isn't working label Feb 14, 2024
@kiedtl
Copy link
Owner Author
kiedtl commented Sep 1, 2024
  • SmolStr/CompactString implementation in Zig
  • Analysis with Heaptrack

@kiedtl
Copy link
Owner Author
kiedtl commented Sep 13, 2024 •
edited
Loading

Worked a bit on this. From analysing allocator deinit stderr output, unfreed allocations are down from 12752 unfreed allocations (before work began), to 6178 unfreed allocations, to 418.

Most of the remaining unfreed allocations seems to be coming from TypeInfo's and random lexer/AST nodes that seem to have been orphaned(?).

Note to future self: create a Box 5E4B type of the form

pub fn Box(comptime T: type) type {
    return struct {
        inner: *T,
        freed: bool = false,
    };
}

that tracks whether an allocation has been freed or not. Then, use it in TypeInfo for Fn, AnySet, Of, Expr.Fn, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kiedtl
0