8000 Updating channel delivery options diff logic needs work · Issue #4375 · knative/eventing · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Updating channel delivery options diff logic needs work #4375
Closed
@vaikas

Description

@vaikas

Describe the bug
Currently, and in here:
#4359 (comment)

we store two functions which makes it very hard (if not impossible) to determine if delivery functions have differed because the original args are not stored away. This means that for some changes we do not update the delivery options. We should probably store the arguments along for the ride (as well as create the closures) so that we can figure out if things have changed.

Expected behavior
Changes to channel delivery options should be reflected at runtime.

To Reproduce
Steps to reproduce the behavior.

Knative release version

Additional context
Add any other context about the problem here such as proposed priority

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/channelskind/bugCategorizes issue or PR as related to a bug.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0