From d1af8f588087cd900df27bc595030ce10b97c22f Mon Sep 17 00:00:00 2001 From: Scott Nichols Date: Thu, 23 Jul 2020 11:47:21 -0700 Subject: [PATCH] remove reconciled normal event from mtbroker --- pkg/reconciler/mtbroker/broker.go | 11 +---------- pkg/reconciler/mtbroker/broker_test.go | 4 ---- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/pkg/reconciler/mtbroker/broker.go b/pkg/reconciler/mtbroker/broker.go index 4d356a55a72..fe56094a20a 100644 --- a/pkg/reconciler/mtbroker/broker.go +++ b/pkg/reconciler/mtbroker/broker.go @@ -54,11 +54,6 @@ import ( "knative.dev/pkg/system" ) -const ( - // Name of the corev1.Events emitted from the Broker reconciliation process. - brokerReconciled = "BrokerReconciled" -) - type Reconciler struct { eventingClientSet clientset.Interface dynamicClientSet dynamic.Interface @@ -96,10 +91,6 @@ type ReconcilerArgs struct { FilterServiceAccountName string } -func newReconciledNormal(namespace, name string) pkgreconciler.Event { - return pkgreconciler.NewEvent(corev1.EventTypeNormal, brokerReconciled, "Broker reconciled: \"%s/%s\"", namespace, name) -} - func (r *Reconciler) ReconcileKind(ctx context.Context, b *eventingv1.Broker) pkgreconciler.Event { triggerChan, err := r.reconcileKind(ctx, b) if err != nil { @@ -268,7 +259,7 @@ func (r *Reconciler) FinalizeKind(ctx context.Context, b *eventingv1.Broker) pkg if err := r.propagateBrokerStatusToTriggers(ctx, b.Namespace, b.Name, nil); err != nil { return fmt.Errorf("Trigger reconcile failed: %v", err) } - return newReconciledNormal(b.Namespace, b.Name) + return nil } // reconcileChannel reconciles Broker's 'b' underlying channel. diff --git a/pkg/reconciler/mtbroker/broker_test.go b/pkg/reconciler/mtbroker/broker_test.go index 57c02474049..2d986663473 100644 --- a/pkg/reconciler/mtbroker/broker_test.go +++ b/pkg/reconciler/mtbroker/broker_test.go @@ -167,9 +167,6 @@ func TestReconcile(t *testing.T) { WithBrokerDeletionTimestamp), imcConfigMap(), }, - WantEvents: []string{ - Eventf(corev1.EventTypeNormal, "BrokerReconciled", `Broker reconciled: "test-namespace/test-broker"`), - }, }, { Name: "nil config", Key: testKey, @@ -582,7 +579,6 @@ func TestReconcile(t *testing.T) { }, WantEvents: []string{ finalizerUpdatedEvent, - Eventf(corev1.EventTypeNormal, "BrokerReconciled", `Broker reconciled: "test-namespace/test-broker"`), }, }, { Name: "Broker being deleted, marks trigger as not ready due to broker missing, fails",