From 6e66d194062ae8ccae96647a5a999b317eabe7a1 Mon Sep 17 00:00:00 2001 From: swastik959 Date: Tue, 18 Jun 2024 18:52:24 +0530 Subject: [PATCH 1/2] corrected error msg Signed-off-by: swastik959 --- pkg/knative/deployer.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/knative/deployer.go b/pkg/knative/deployer.go index d45d0c82d9..9857412f23 100644 --- a/pkg/knative/deployer.go +++ b/pkg/knative/deployer.go @@ -965,7 +965,11 @@ func checkResourcesArePresent(ctx context.Context, namespace string, referencedS for s := range *referencedSecrets { _, err := k8s.GetSecret(ctx, s, namespace) if err != nil { - errMsg += fmt.Sprintf(" referenced Secret \"%s\" is not present in namespace \"%s\"\n", s, namespace) + if errors.IsForbidden(err) { + errMsg += fmt.Sprintf(" Ensure that the service account has the necessary permissions to access the secret.\n") + } else { + errMsg += fmt.Sprintf(" referenced Secret \"%s\" is not present in namespace \"%s\"\n", s, namespace) + } } } From 4247e8fc31eea9d9ef4582b6357819387e616744 Mon Sep 17 00:00:00 2001 From: swastik959 Date: Thu, 20 Jun 2024 19:03:56 +0530 Subject: [PATCH 2/2] lintted Signed-off-by: swastik959 --- pkg/knative/deployer.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/knative/deployer.go b/pkg/knative/deployer.go index 9857412f23..5bb80b276f 100644 --- a/pkg/knative/deployer.go +++ b/pkg/knative/deployer.go @@ -966,7 +966,7 @@ func checkResourcesArePresent(ctx context.Context, namespace string, referencedS _, err := k8s.GetSecret(ctx, s, namespace) if err != nil { if errors.IsForbidden(err) { - errMsg += fmt.Sprintf(" Ensure that the service account has the necessary permissions to access the secret.\n") + errMsg += " Ensure that the service account has the necessary permissions to access the secret.\n" } else { errMsg += fmt.Sprintf(" referenced Secret \"%s\" is not present in namespace \"%s\"\n", s, namespace) }