fix: override default C compiler to cc.exe on MSYS2 #1754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
reviewed
Feb 24, 2025
|
Thanks!! |
This was referenced Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1753
Changes:
cc.exethat points to the default C compiler for the environment.is meant to follow a MSYS2 patch https://github.com/msys2/MINGW-packages/blob/5fd4997c2508f0949366513f0a2dd4347f9c4e77/mingw-w64-lua-luarocks/0001-luarocks_msys2_mingw_w64.patch#L48 that fixes previous issues for them.
Note
I have opened a PR on MSYS2 msys2/MINGW-packages#23494 that fixes this issue. However, I guess that MSYS2 maintainers expect these changes to be first accepted upstream.