Error handling is not graceful in callback function #192
Labels
Comments
|
The idea is that error handling will be handled at the lua level instead of at the C level. The fatal exit here is to prevent strange undefined behavior when errors go uncaught. |
|
After thinking about this for a while, I do think this needs to be handled at the luv level. How exactly does NAN make function luv.makeCallback(fn)
-- do anything custom here if desired
return fn
endAnd so a custom one would wrap in xpcall and route errors function luv.makeCallback(fn)
return function (...)
local args = {...}
local success, err = xpcall(function ()
return fn(unpack(args))
end, debug.traceback)
-- TODO: handle success, and err
end
endThough I worry about the performance hit from adding all these closures to every event source. |
|
See #128 for more related ideas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After I have registered a callback to a luv handle, when the callback need to be called, we use luv_call_callback to call it.
It's is OK when there is no exception when calling the callback function. But when error occured, it just print the stack traceback and call exit to end the process.
I think it is better to provide an alternative way just like "uncaughtException" in nodejs to allow user to do more control.
And I think luv_call_callback should to be exported just like "MakeCallback" in NAN, so it can provide a consistent error handling machanism when I write a extension for luv.
The text was updated successfully, but these errors were encountered: