Replacing TypeRepr, WhereClause and etc with syn types and rust! with quote!.
#949
Comments
|
This makes sense to me, there have been/are improvements to the Rust ecosystem that LALRPOP should take advantage of. Would the main benefits be less code to maintain, a better on ramp to supporting more Rust syntax, and a better story than our current string concatenation? I would hope the downsides in terms of compile/runtime aren't too steep but that is hard to know ahead of time. We can probably turn off some of syn's feature flags to limit the compile time increase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First, would it be appreciated if I replace some of the current types used for code generation with the equivalent syn types.
Second, replace the
rust!macro with quote.You guys have most likely already thought of this, there might be reasons like compile time to avoid additional dependencies. However it might make the code generation more readable.
Kind regards
Jacob
The text was updated successfully, but these errors were encountered: