8000 Class transform does not work in Wagner project · Issue #113 · lebab/lebab · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Class transform does not work in Wagner project #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marvelsrp opened this issue Apr 1, 2016 · 3 comments
Closed

Class transform does not work in Wagner project #113

marvelsrp opened this issue Apr 1, 2016 · 3 comments
Labels
enhancement

Comments

@marvelsrp
Copy link

I try convert https://github.com/marvelsrp/Wagner/blob/master/Wagner.base.js to ES6.
The result is not satisfactory
@nene
Copy link
Collaborator
nene commented Apr 1, 2016

You should be more specific than that.

  • Does Lebab introduce any bugs in your code?
  • Does it transform something that it shouldn't?
  • Does it leave something untransformed when it should?

My guess is that you're expecting Lebab to transform all these prototype manipulations to ES6 classes...

  • Currently Lebab does not recognize inheritance which all of the "classes" in there seem to be using.
  • Additionally Lebab only handles the case where class is defined as a variable (e.g. it could recognize var SymmetricPass but it won't touch WAGNER.SymmetricPass).

The latter is more feasible to be fixed some time soon. Inheritance is a whole larger topic - there are so many possibilities for implementing it in ES5.

nene added a commit that referenced this issue Apr 2, 2016
@nene
Document the namespacing bug in class transform
beb0cd7 
Refs #113
@nene nene changed the title Wagner.base.js to ES6. Class transform does not recognize namespacing Apr 2, 2016
@nene
Copy link
Collaborator
nene commented Apr 2, 2016

Changed the issue title to make the whole issue be about namespacing support.

Lack of inheritance support is covered by issue #33

@BrendanAnnable BrendanAnnable mentioned this issue Jun 13, 2016
Closed
@nene nene mentioned this issue Jul 7, 2016
Open
@nene nene changed the title Class transform does not recognize namespacing Class transform does not work in Wagner project Jul 7, 2016
@nene
Copy link
Collaborator
nene commented Jul 7, 2016

Closing in favor of a duplicate issue: #146

@nene nene closed this as completed Jul 7, 2016
@Bamblip Bamblip mentioned this issue Jul 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nene @marvelsrp
0