8000 Suggestion on code · Issue #4 · leonshen95/DetectUtilityPoles · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Suggestion on code #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cjustacoder opened this issue Nov 3, 2018 · 0 comments
Open

Suggestion on code #4

cjustacoder opened this issue Nov 3, 2018 · 0 comments

Comments

@cjustacoder
Copy link

It seems you have a heavy load work on your program, good job. Here are some suggestion, I hope these may help you to some extent.

Code structure

labelImg.py

This code is extremely long. I don't suggest write code in this style. It's hard for others to read your code and figure out what is going on. And it's also difficult for you to debug and manage your code.
You should try to break this code into several segments according to their function. Making library consist of these function and call these function in your main program. Or you can write those functional part into functions in this file can write the main function to call these function. This should also work well.

examplecapture.py

It's good to see you write code in functions. Although you have added many commons on your code and this help to understand how these codes work well, you should add some description on functions and arguments. It's also important to know what functions are doing and how to use these functions with arguments inside. This may help others understand your program a lot. Adding more "docstring" may also be helpful to build up a library.

Project approach

UtilitPoles detection

I think recognize the hole part of poles is very improtant. You should not only recognize the top of utility poles, but the whole parts of the poles. Because I think it's better to help you know the location if you know where the bottom is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant
0