8000 Test heif/heif_read fails with libheif 1.18.0+ · Issue #889 · libgd/libgd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test heif/heif_read fails with libheif 1.18.0+ #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
loqs opened this issue Sep 15, 2024 · 5 comments · May be fixed by #895
Closed

Test heif/heif_read fails with libheif 1.18.0+ #889

loqs opened this issue Sep 15, 2024 · 5 comments · May be fixed by #895
Assignees
@cmb69
Labels
tests

Comments

@loqs
Copy link
loqs commented Sep 15, 2024

Describe the bug
The test heif/heif_read fails with libheif 1.18.0 or newer which contain strukturag/libheif@0b23606. The failing test in gd appears to be triggerd by a new check in libheif that returns an error Image has no 'ispe' property from heif_context_read_from_memory_without_copy for tests/heif/label.heic.

To Reproduce
Steps to reproduce the behavior:

 ./bootstrap.sh
 ./configure \
    --prefix=/usr \
    --disable-rpath
make
make check

Expected behavior
All checks should pass.

Actual results
The test heif/heif_read fails with:

FAIL: heif/heif_read
====================

dlopen: libavcodec.so.61: cannot open shared object file: No such file or directory
GD Warning: gd-heif context creation failed
heif/heif_read.c:23: Assert failed in <heif/heif_read.c:23>
FAIL heif/heif_read (exit status: 2)

Environment (please complete the following information):

  • OS: Arch Linux
  • Version rolling
  • fontconfig 2.15.0
  • libxpm 3.5.17
  • libwebp 1.4.0
  • libavif 1.1.1
  • libheif 1.18.2

Additional context
test-suite.log
https://gitlab.archlinux.org/archlinux/packaging/packages/gd/-/issues/1
@cmb69
Copy link
Member
cmb69 commented Oct 14, 2024

Indeed, all four MinGW CI jobs are failing because of this.

I do not understand, though, what this test is really supposed to be testing. The comment is

libgd/tests/heif/heif_read.c

Lines 2 to 3 in 6e42ee8

* Simple test case that confirms the failure of using `gdImageCreateFromHeif`
* with a NULL pointer.

but apparently, the test checks for the opposite. Maybe @YakoYakoYokuYoku can clarify?

@cmb69 cmb69 added the tests label Oct 14, 2024
@cmb69 cmb69 mentioned this issue Oct 14, 2024
Merged
@YakoYakoYokuYoku
Copy link
Contributor

Maybe @YakoYakoYokuYoku can clarify?

It was meant to check that libgd indeed supports reading HEIF images, can't remember why the me from the past chose such confusing words.

@YakoYakoYokuYoku YakoYakoYokuYoku mentioned this issue Oct 26, 2024
Open
@YakoYakoYokuYoku
Copy link
Contributor

I'm in doubt, because FFmpeg can read the image but libheif cannot. Said image was produced with a version previous to v1.12.0, possibly v1.10.0, which didn't add the elusive ispe property. This is an upstream issue with libheif, so an issue should be opened there.

@YakoYakoYokuYoku YakoYakoYokuYoku mentioned this issue Oct 26, 2024
Closed
@cmb69
Copy link
Member
cmb69 commented Dec 21, 2024

The issue has been resolved upstream, and the MinGW builds (using libheif 1.19.5-2) are green again (one fails for another test case), so I'd close this issue if the test wasn't failing for me locally with a self-built libheif 1.19.5 (using libde265 1.0.15). I'll check that ASAP.

@cmb69 cmb69 self-assigned this Dec 21, 2024
@cmb69
Copy link
Member
cmb69 commented Dec 22, 2024

if the test wasn't failing for me locally

Actually another test fails for me (heif_im2im), so I consider this issue to be resolved.

@cmb69 cmb69 closed this as completed Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmb69 cmb69

Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix HEIF image handling with uninitialized library YakoYakoYokuYoku/libgd
3 participants
@cmb69 @loqs @YakoYakoYokuYoku
0