8000 feat: Restructure Agent edit page by tatianainama · Pull Request #15815 · lightdash/lightdash · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Restructure Agent edit page #15815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

feat: Restructure Agent edit page #15815

merged 1 commit into from
Jul 11, 2025
+325 −270

Conversation

tatianainama
Copy link
Contributor
@tatianainama tatianainama commented Jul 10, 2025 •
edited
Loading

Description:

Redesigned AI Agent edit page:

  • Improved page structure with defined sections
  • Simplified the Slack integration instructions text
  • Moved action buttons to the top of the page for better accessibility
  • Enhanced typography and spacing for improved readability

image.png

image.png

@tatianainama Graphite App
Copy link
Contributor Author
tatianainama commented Jul 10, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tatianainama tatianainama mentioned this pull request Jul 10, 2025
Open
4 tasks
@tatianainama tatianainama force-pushed the 07-09-feat_restructure_agent_edit_page branch from 4c3e327 to c4afc4b Compare July 10, 2025 16:38
@tatianainama tatianainama marked this pull request as ready for review July 10, 2025 16:38
@github-actions GitHub Actions
Copy link

Your preview environment pr-15815 has been deployed.

Preview environment endpoints are available at:

@github-actions GitHub Actions
Copy link

Preview environment logs can be accessed at: https://console.cloud.google.com/logs/query;query=resource.labels.namespace_name%3D%22pr-15815%22;duration=PT30M?project=lightdash-previews

@tatianainama tatianainama requested a review from a team July 10, 2025 17:09
@notgiorgi Graphite App
Copy link
Contributor

Can we hide this warning under a Enable Slack integration toggle? Right now it feels like I have a problem even though I'm not planning to use agent w/ slack

CleanShot 2025-07-10 at 21.16.08@2x.png

IrakliJani
IrakliJani approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor
@IrakliJani IrakliJani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great!

make slack stepper pop less

tldr;

I think the stepper for the Slack integration pops up too much - would love to see it be less prominent. But since it's not part of this PR, just something to keep in mind.

@tatianainama Graphite App
Copy link
Contributor Author
tatianainama commented Jul 11, 2025 •
edited
Loading

thanks both for the feedback! I'll work on another pr on these slack integration things 💪 #15826

@tatianainama tatianainama force-pushed the 07-09-feat_restructure_agent_edit_page branch from c4afc4b to e39a087 Compare July 11, 2025 11:29
@github-actions GitHub Actions
Copy link

Preview environment logs can be accessed at: https://console.cloud.google.com/logs/query;query=resource.labels.namespace_name%3D%22pr-15815%22;duration=PT30M?project=lightdash-previews

@tatianainama tatianainama force-pushed the 07-09-feat_restructure_agent_edit_page branch from e39a087 to 578cad7 Compare July 11, 2025 13:43
@github-actions GitHub Actions
Copy link

Preview environment logs can be accessed at: https://console.cloud.google.com/logs/query;query=resource.labels.namespace_name%3D%22pr-15815%22;duration=PT30M?project=lightdash-previews

@tatianainama Graphite App
Copy link
Contributor Author
tatianainama commented Jul 11, 2025 •
edited
Loading

Merge activity

  • Jul 11, 3:23 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 11, 3:23 PM UTC: @tatianainama merged this pull request with Graphite.

@tatianainama tatianainama merged commit b1f8251 into main Jul 11, 2025
29 of 31 checks passed
@tatianainama tatianainama deleted the 07-09-feat_restructure_agent_edit_page branch July 11, 2025 15:23
lightdash-bot pushed a commit that referenced this pull request Jul 11, 2025
@semantic-release-bot
chore(release): 0.1806.0
ba6b31b 
# [0.1806.0](0.1805.0...0.1806.0) (2025-07-11)

### Features

* Restructure Agent edit page ([#15815](#15815)) ([b1f8251](b1f8251))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1806.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IrakliJani IrakliJani IrakliJani approved these changes

Assignees

@tatianainama tatianainama

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tatianainama @notgiorgi @lightdash-bot @IrakliJani
0