fix: properly quote table names in SQL query builder #15819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Your preview environment pr-15819 has been deployed. Preview environment endpoints are available at: |
|
Preview environment logs can be accessed at: https://console.cloud.google.com/logs/query;query=resource.labels.namespace_name%3D%22pr-15819%22;duration=PT30M?project=lightdash-previews |
133e400 to
7b63a68
Compare
|
Preview environment logs can be accessed at: https://console.cloud.google.com/logs/query;query=resource.labels.namespace_name%3D%22pr-15819%22;duration=PT30M?project=lightdash-previews |
lightdash-bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
## [0.1803.1](0.1803.0...0.1803.1) (2025-07-11) ### Bug Fixes * properly quote table names in SQL query builder ([#15819](#15819)) ([5873ba6](5873ba6))
|
🎉 This PR is included in version 0.1803.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #15811
Query working in Lightdash
Same query working in snowflake
Description:
Fixed SQL query generation in MetricQueryBuilder by properly quoting table names in primary key references. This ensures compatibilit 8000 y with databases that require table names to be quoted, especially when they contain special characters or reserved keywords.