8000 Lightdash should correctly deduplicate/calculate metrics coming from one-to-many joins · Issue #10361 · lightdash/lightdash · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Lightdash should correctly deduplicate/calculate metrics coming from one-to-many joins #10361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TuringLovesDeathMetal opened this issue Jun 11, 2024 · 8 comments
Open

Lightdash should correctly deduplicate/calculate metrics coming from one-to-many joins #10361

TuringLovesDeathMetal opened this issue Jun 11, 2024 · 8 comments
Labels
✨ feature-request Request for a new feature or functionality
Milestone
👯‍♀️ Deduplicatin...

Comments

@TuringLovesDeathMetal
Copy link
Contributor

Description

Today, in Lightdash, if you have a one-to-many join (i.e. Table A joins Table B 1:N) and then you query a metric from the "one" join that's an aggregate (e.g. use a field from Table B, but then sum a value from Table A), then you get incorrect metric results.

The first step to handling this is actually being able to identify the metrics that will cause these issues (#961). But, eventually, we need to actually handle deduplication in these metric calculations.

This issue is about handling the deduplication.

Approach
@TuringLovesDeathMetal TuringLovesDeathMetal added the ✨ feature-request Request for a new feature or functionality label Jun 11, 2024
@yu-iskw yu-iskw mentioned this issue Jul 30, 2024
Open
@lightdash-bot
Copy link
Collaborator

This issue was mentioned by a user in slack: https://lightdash.slack.com/archives/C04KD95TF0U/p1725476387180909?thread_ts=1725476387.180909&cid=C04KD95TF0U

@lightdash-bot
Copy link
Collaborator

This issue was mentioned by a user in slack: https://lightdash-community.slack.com/archives/C03MG2VTR08/p1731945923941059?thread_ts=1731945923.941059&cid=C03MG2VTR08

@lightdash-bot
Copy link
Collaborator

This issue was mentioned by a user in slack: https://lightdash.slack.com/archives/C05UPNC0LGP/p1734374612987889?thread_ts=1734374612.987889&cid=C05UPNC0LGP

@lightdash-bot
Copy link
Collaborator

This issue was mentioned by a user in slack: https://lightdash-community.slack.com/archives/C067S48BHRP/p1737388379511399?thread_ts=1737388379.511399&cid=C067S48BHRP

@jpetey75 jpetey75 mentioned this issue Mar 27, 2025
Closed
@lightdash-bot
Copy link
Collaborator

This issue was mentioned by a user in slack: https://lightdash.slack.com/archives/C02DGV9RWKV/p1743696028062889?thread_ts=1743696028.062889&cid=C02DGV9RWKV

@lightdash-bot
Copy link
Collaborator

This issue was mentioned by a user in slack: https://lightdash.slack.com/archives/C07MRATGAKY/p1743769713432319?thread_ts=1743769713.432319&cid=C07MRATGAKY

@lightdash-bot
Copy link
Collaborator

This issue was mentioned by a user in slack: https://lightdash.slack.com/archives/C02NM5X89QS/p1744730509955889?thread_ts=1744730509.955889&cid=C02NM5X89QS

@lightdash-bot
Copy link
Collaborator

This issue was mentioned by a user in slack: https://lightdash.slack.com/archives/C08RYCQJJCV/p1747079419585859?thread_ts=1747079419.585859&cid=C08RYCQJJCV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ feature-request Request for a new feature or functionality
Projects
None yet
Milestone
👯‍♀️ Deduplicating metric results (ca...
Development

No branches or pull requests
2 participants
@TuringLovesDeathMetal @lightdash-bot
0