8000 LidoOracle: new interface and pushing principles · Issue #129 · lidofinance/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

LidoOracle: new interface and pushing principles #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ongrid opened this issue Nov 11, 2020 · 1 comment · Fixed by #153
Closed

LidoOracle: new interface and pushing principles #129

ongrid opened this issue Nov 11, 2020 · 1 comment · Fixed by #153
Assignees
@lxzrv
Labels
enhancement New feature or request
Milestone
RC2

Comments

@ongrid
Copy link
Contributor
ongrid commented Nov 11, 2020 •
edited
Loading

Base branch: lip_3_oracle

  • ReportInterval will be replaced to just epochIds (the same IDs as beacon chain states have for clarity). Method setReportIntervalDuration and event ReportIntervalDurationChanged, REPORT_INTERVAL_DURATION are deprecated and to be removed.
  • The last state pushed to lido now called lastPushedEpochId instead of lastFinalizedReportInterval
  • The accept reportBeacon transactions from oracles if lastPushedEpochId < _epochId <= getCurrentReportableEpochID(), revert if not.
  • To gather reports for different epochs they should be stored in the map instead of currentlyAggregatedReportInterval flat variables.
    map gatheredReports[_epochId] = { Report, contrinutionBitmask }
  • To save gas, reports are tightly packed in the Report struct
struct Report {
        uint128 beaconValidators;
        uint128 beaconBalance;
    }

  • remove getLatestData since it doesn't make any sense.

  • Implement beaconSpec struct (oracle daemons take configuration from it). Implemented as public variable and its setter

    // timing parameters of Beacon Chain specification (may be overriden by corresponding setter)
    // See https://github.com/ethereum/eth2.0-specs/blob/dev/specs/phase0/beacon-chain.md
    struct BeaconSpec {
        uint64 slotsPerEpoch = 32; // SLOTS_PER_EPOCH
        uint64 secondsPerSlot = 12 // SECONDS_PER_SLOT
        // The genesis expected to happen on Dec 1, 2020, 12pm UTC
        // But the exact time depends on actual staking and will be known post factum
        uint64 genesisTime = 1606824000 
    }
    BeaconSpec public beaconSpec;
    
    function setBeaconSpec(uint64 slotsPerEpoch, uint64 secondsPerSlot, uint64 genesisTime) public {
        // Some require for sanity checks here
        beaconSpec.slotsPerEpoch = slotsPerEpoch;
        beaconSpec.secondsPerSlot = secondsPerSlot;
        beaconSpec.genesisTime = genesisTime;
    }
  • Implement public/external getters for oracle daemons: getCurrentReportableEpoch (define public vs external) and getCurrentReportableEpochID() (define external vs internal)
    // Returns the current reportable epoch object with its timestamp boundaries.
    // Used by oracle daemons
    function getCurrentReportableEpoch() public {
        epochId = getCurrentEpochID();
        // Use SafeMath here
        startTimestamp = epochId * beaconSpec.secondsPerSlot * beaconSpec.slotsPerEpoch
        endTimestamp = (epochId + 1) * beaconSpec.secondsPerSlot * beaconSpec.slotsPerEpoch - 1
    }
    
    // Returns the current epochId
    function getCurrentReportableEpochID() internal {
        // Switch to safeMath
        return(block.timestamp / beaconSpec.secondsPerSlot / beaconSpec.slotsPerEpoch);
    }
  • Cosmetic: more clear naming on quorum-related methods, see list of cosmetic issues below
  • Cosmetic: _tryFinalize is a bad name for new implementation since it doesn't require finalisation. The quorum-related logic should be renamed to _isQuorumReached(uint256 _epochId). pushBeacon and updating lastPushedEpochId can be called on the same level.
  • Cosmetic: all the introduced and refactored entities should have doxygens
  • Unit tests (integration tests will probably conflict with Lido pushBeacon with _beaconValidators amount for proper reward calculation #128)
  • Update Aragon's UI spec, deploy and check it by eyes. Suldin will help if needed.

Reference: Lido's interface:

contract Lido {
    // called by the oracle contract
    function pushBeacon(uint128 _beaconValidators, uint256 _beaconBalance) external {
        
    }
}

Solves: #110, Related: #4, Cosmetic: #71, #87, #119
@ongrid ongrid added the 8000 enhancement New feature or request label Nov 11, 2020
@ongrid ongrid added this to the RC2 milestone Nov 11, 2020
@skozin
Copy link
Member
skozin commented Nov 11, 2020

Have you already decided on how you're going to implement mode calc for the structured data?

lxzrv pushed a commit that referenced this issue Nov 16, 2020
Add new functions related to lip_3 #129
f88983f
lxzrv pushed a commit that referenced this issue Nov 16, 2020
Oracle: remove deprecated functions, fix new methods, rewrite tests #129
b25e77b
lxzrv pushed a commit that referenced this issue Nov 16, 2020
Add new functions related to lip_3 #129
b37af14
lxzrv pushed a commit that referenced this issue Nov 16, 2020
Oracle: remove deprecated functions, fix new methods, rewrite tests #129
de56aa2
@lxzrv lxzrv mentioned this issue Nov 16, 2020
Merged
lxzrv pushed a commit that referenced this issue Nov 16, 2020
Oracle: remove deprecated functions, fix new methods, rewrite tests #129
81d9a34
lxzrv pushed a commit that referenced this issue Nov 16, 2020
Fix setBeaconSpec method, template, tests #129
62cc4bf
lxzrv pushed a commit that referenced this issue Nov 17, 2020
Add getCurrentFrame method to oracle #129
ae3e242
lxzrv pushed a commit that referenced this issue Nov 17, 2020
Apply cosmetic fixes #129
f3717e2
lxzrv pushed a commit that referenced this issue Nov 17, 2020
Apply cosmetic fixes #129
ca74862
lxzrv pushed a commit that referenced this issue Nov 17, 2020
Add new functions related to lip_3 #129
8e835cb
lxzrv pushed a commit that referenced this issue Nov 17, 2020
Oracle: remove deprecated functions, fix new methods, rewrite tests #129
80b6e2a
lxzrv pushed a commit that referenced this issue Nov 17, 2020
Fix setBeaconSpec method, template, tests #129
ecf39a8
lxzrv pushed a commit that referenced this issue Nov 17, 2020
Add getCurrentFrame method to oracle #129
d76a249
lxzrv pushed a commit that referenced this issue Nov 17, 2020
Apply cosmetic fixes #129
e506af8
@ongrid ongrid mentioned this issue Nov 18, 2020
Merged
ongrid pushed a commit that referenced this issue Nov 22, 2020
@ongrid
Add new functions related to lip_3 #129
936d9a3
ongrid pushed a commit that referenced this issue Nov 22, 2020
@ongrid
Oracle: remove deprecated functions, fix new methods, rewrite tests #129
8df1d4f
ongrid pushed a commit that referenced this issue Nov 22, 2020
@ongrid
Fix setBeaconSpec method, template, tests #129
a1b1559
ongrid pushed a commit that referenced this issue Nov 22, 2020
@ongrid
Add getCurrentFrame method to oracle #129
3c4488c
ongrid pushed a commit that referenced this issue Nov 22, 2020
@ongrid
Apply cosmetic fixes #129
fb1343b
ongrid pushed a commit that referenced this issue Nov 22, 2020
@ongrid
Add new functions related to lip_3 #129
655867e
ongrid pushed a commit that referenced this issue Nov 22, 2020
@ongrid
Oracle: remove deprecated functions, fix new methods, rewrite tests #129
ba6bb98
ongrid pushed a commit that referenced this issue Nov 22, 2020
@ongrid
Fix setBeaconSpec method, template, tests #129
9c0bf09
ongrid pushed a commit that referenced this issue Nov 22, 2020
@ongrid
Add getCurrentFrame method to oracle #129
fa5d434
ongrid pushed a commit that referenced this issue Nov 22, 2020
@ongrid
Apply cosmetic fixes #129
b68d254
skozin pushed a commit that referenced this issue Nov 22, 2020
@skozin
Add new functions related to lip_3 #129
7c77371
skozin pushed a commit that referenced this issue Nov 22, 2020
@skozin
Oracle: remove deprecated functions, fix new methods, rewrite tests #129
b7eae7a
skozin pushed a commit that referenced this issue Nov 22, 2020
@skozin
Fix setBeaconSpec method, template, tests #129
dd97aa3
skozin pushed a commit that referenced this issue Nov 22, 2020
@skozin
Add getCurrentFrame method to oracle #129
b3b6eff
skozin pushed a commit that referenced this issue Nov 22, 2020
@skozin
Apply cosmetic fixes #129
bc28e13
krogla pushed a commit that referenced this issue Jan 26, 2021
Add new functions related to lip_3 #129
dd93cda
krogla pushed a commit that referenced this issue Jan 26, 2021
Oracle: remove deprecated functions, fix new methods, rewrite tests #129
5b8b45b
krogla pushed a commit that referenced this issue Jan 26, 2021
Fix setBeaconSpec method, template, tests #129
09d649d
krogla pushed a commit that referenced this issue Jan 26, 2021
Add getCurrentFrame method to oracle #129
07b94e3
krogla pushed a commit that referenced this issue Jan 26, 2021
Apply cosmetic fixes #129
2858c9d
dechjo pushed a commit to dechjo/lido-dao that referenced this issue Jan 26, 2021
@skozin
Add new functions related to lip_3 lidofinance#129
7062244
dechjo pushed a commit to dechjo/lido-dao that referenced this issue Jan 26, 2021
@skozin
Oracle: remove deprecated functions, fix new methods, rewrite tests l…
8d85aeb 
…idofinance#129
dechjo pushed a commit to dechjo/lido-dao that referenced this issue Jan 26, 2021
@skozin
Fix setBeaconSpec method, template, tests lidofinance#129
e59c060
dechjo pushed a commit to dechjo/lido-dao that referenced this issue Jan 26, 2021
@skozin
Add getCurrentFrame method to oracle lidofinance#129
8fe8340
dechjo pushed a commit to dechjo/lido-dao that referenced this issue Jan 26, 2021
@skozin
Apply cosmetic fixes lidofinance#129
0f5f27b
tamtamchik pushed a commit that referenced this issue Oct 11, 2024
@mkurayan
Merge pull request #129 from lidofinance/feat/sr-1.5-merge-negative-r…
afc1908 
…ebase

Feat/sr 1.5 merge negative rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lxzrv lxzrv

Labels
enhancement New feature or request
Projects
None yet
Milestone
RC2
Development

Successfully merging a pull request may close this issue.

LIP-3 Oracle interface and reward algorithm for v0.2.x lidofinance/core
3 participants
@skozin @ongrid @lxzrv
0