8000 Set TypeScript 5.1 as the minimum TS version by marcbouchenoire · Pull Request #18 · liveblocks/frimousse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Set TypeScript 5.1 as the minimum TS version #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 15, 2025
Merged

Set TypeScript 5.1 as the minimum TS version #18

merged 6 commits into from
Jul 15, 2025

Conversation

marcbouchenoire
Copy link
Collaborator

This PR removes unnecessary return types and updates needed ones from ReactNode to JSX.Element, because TypeScript didn't support using ReactNode for return types on versions lower than 5.1.

Fixes #17.

@marcbouchenoire marcbouchenoire mentioned this pull request Jun 24, 2025
Closed
@marcbouchenoire
Copy link
Collaborator Author

The current state of the PR prevents using primitive values like string or null, I'll revisit this later.

< 8000 div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="IC_kwDONzsS0863K8GC">
@marcbouchenoire
Copy link
Collaborator Author

I couldn't find a way to support TS <= 5.1 and primitive values like string or null on TS >= 5.1, so I'm setting 5.1 as the minimum TS version.

@marcbouchenoire marcbouchenoire changed the title Fix return types to support TS version lower than 5.1 Set TypeScript 5.1 as the minimum TS version Jul 15, 2025
@marcbouchenoire marcbouchenoire merged commit c43a918 into main Jul 15, 2025
5 checks passed
@marcbouchenoire marcbouchenoire deleted the support-TS-5.1 branch July 15, 2025 10:41
@pauldambra pauldambra mentioned this pull request Jul 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues when using frimousse with TypeScript versions below 5.1
1 participant
@marcbouchenoire
0