8000 Delegated stake NaN display bug · Issue #236 · livepeer/explorer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Delegated stake NaN display bug #236
@rickstaa

Description

@rickstaa

Problem description

Upon closer inspection, I observed that the explorer displays NaN when an orchestrator has staked less than 1e-6 LPT (e.g. https://explorer.livepeer.org/accounts/0x0074780feff1fd0277fad6ccdb5a29908df6051f/orchestrating). After investigating, it appears that this issue stems from a bug in the numeral library, as documented in this GitHub issue: adamwdraper/Numeral-js#596.

Recommendation

Although this is not a big deal considering that the numeral-js library is currently unmaintained and the bug remains unresolved, I propose migrating to the actively maintained https://github.com/BenjaminVanRyseghem/numbro library. This alternative library has already addressed the bug mentioned, solving this issue and making the explorer more future-proof.

Extra info

image

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0