8000 [StripDebugInfoWithPred] Use worklist instead of recursion by uenoku · Pull Request #8435 · llvm/circt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[StripDebugInfoWithPred] Use worklist instead of recursion #8435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

uenoku
Copy link
Member
@uenoku uenoku commented Apr 22, 2025

As it caused stack overflow it is changed to use worklist. The behavior is slightly different since it flattens fused loc and dedupluicates locations.

@uenoku uenoku requested review from seldridge and youngar April 22, 2025 19:19
Copy link
Member
@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the quick fix.

Do we have any tests of this already? (I couldn't find any.)

@uenoku
Copy link
Member Author
uenoku commented Apr 22, 2025

Thanks, a test was added.

@uenoku uenoku merged commit d4eb67a into main Apr 22, 2025
5 checks passed
@uenoku uenoku deleted the dev/hidetou/ite branch April 22, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0