8000 [Feature request] Supporting unified QR-Codes (BIP21+BOLT12) · Issue #1812 · lnbits/lnbits · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Feature request] Supporting unified QR-Codes (BIP21+BOLT12) #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arbadacarbaYK opened this issue Jul 8, 2023 · 4 comments
Open

[Feature request] Supporting unified QR-Codes (BIP21+BOLT12) #1812

arbadacarbaYK opened this issue Jul 8, 2023 · 4 comments
Assignees
@talvasconcelos
Labels
feature request New feature request

Comments

@arbadacarbaYK
Copy link
Contributor
arbadacarbaYK commented Jul 8, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
Wallet of Satoshi and Aqua Wallet abstract the need to understand with what you are paying. Goal should be iin general that users fund a wallet by one of the supported types (LN, onchain, Liquid, Minnts and so on) and can spend it on whatever comes along.
Generating and reading as many payment methods as possible will make LNbits more interoperable
and ease the overall UX and abstract the asset from the user.
This is expecially interesting for any sort of checkout (tpos, nostrmarket, satspay/wordpress plugin)

With this is mind concerning the technical solution this FR intends to push supporting and generating Unified-QR-Codes (BIP21) on LNbits.
For clarification: BIP21 means only 1 QR on one screen instead of two.
Would be wonderful if BIP21 also works for Boltcard extension and voucher.

Prerequisite : onchain wallet extension is installed and has a (synched when its about withdrawing) onchain wallet.

SatsPay now
Bildschirmfoto 2023-07-07 um 22 37 16

Unified QR codes hold additional data, meaning they can become large and cause scanning difficulties with some devices. Therefore preferably this is mixed with introducing BOLT12 to still allow presenting slim QRs !
Especially for Boltcard that might be a need

Write a UQR with LNbits

  • Dynamic invoices presented via TPoS, SatsPay, Tipjar, Invoices, Paywall, Streamer copilot, ..
  • Static payment UQR that can be presented, printed, written to a NFC-tag or used in other extensions

The checkboxes in those extensions` config part should leave in favour of an attional combobox for the onchain wallet., onchain can be NULL. Where both are given present in consequence a UQR iadditionally / instead.

Group 96

Important

  • Tip from the BIP21/12 webpage (https://bitcoinqr.dev/) : If its a zero-amount-invoice and the user switches between the "units" to pay delete the amount to prevent expensive user mistakes.

Describe alternatives you've considered

  • Reading has to be supported for the old and new QRs. There will always be wallets, which cannot handle them. Still it should be the goal so a starting support is a push in that direction for others, too
  • Animated QRs are an alternative solution that should be more widely supported than this BIP/s
  • Give a hint notice on the Onchain-QR tab when the fee is lower onchain than on btcln (sic)
  • With the DFX extension that could even include asynchronous fiat on/offramps
  • With the Cashu extension also mint-QRs could be included

The existing tasks of core and extensions (e.g. Scrub + Split + lnurldevices + Boltz) may not get broken by this change.

Additional context
@arbadacarbaYK arbadacarbaYK added the feature request New feature request label Jul 8, 2023
@talvasconcelos
Copy link
Collaborator

LNbits can already read BIP21 QR codes as per #1634

Not yet able to create...

@talvasconcelos talvasconcelos self-assigned this Sep 25, 2023
@arbadacarbaYK
Copy link
Contributor Author

This wasnt just about reading but generating unified QRs also. Wanted to somewhere collect where to change what to support.

Apart from that reading doesnt work.
photo_2023-09-25_20-36-05

@talvasconcelos talvasconcelos mentioned this issue Oct 5, 2023
Merged
@motorina0
Copy link
Collaborator

@talvasconcelos whats the status here?

@talvasconcelos
Copy link
Collaborator

Let's keep it open until we have BOLT12 support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talvasconcelos talvasconcelos

Labels
feature request New feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@motorina0 @talvasconcelos @arbadacarbaYK
0