8000 🐛 fix(mermaid): firefox mermaid show error by kingsword09 · Pull Request #8270 · lobehub/lobe-chat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🐛 fix(mermaid): firefox mermaid show error #8270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2025
Merged

🐛 fix(mermaid): firefox mermaid show error #8270

merged 1 commit into from
Jun 28, 2025
+1 −1

Conversation

kingsword09
Copy link
Contributor
@kingsword09 kingsword09 commented Jun 26, 2025 •
edited by sourcery-ai bot
Loading

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

closes: #8243

已经在 @lobehub/ui@2.7.3 进行了修复 lobehub/lobe-ui#377

📝 补充信息 | Additional Information

Summary by Sourcery

Bump @lobehub/ui to v2.7.3 to include the fix for the Mermaid rendering error in Firefox

Bug Fixes:

  • Fix Mermaid rendering errors in Firefox via upstream @lobehub/ui v2.7.3

Chores:

  • Update @lobehub/ui dependency to ^2.7.3 in package.json

@vercel Vercel
Copy link
vercel bot commented Jun 26, 2025

@kingsword09 is attempting to deploy a commit to the LobeHub Community Team on Vercel.

A member of the Team first needs to authorize it.

@sourcery-ai Sourcery AI
Copy link
Contributor
sourcery-ai bot commented Jun 26, 2025 •
edited
Loading

Reviewer's Guide

This PR resolves the Firefox-specific Mermaid rendering error by upgrading the @lobehub/ui dependency to v2.7.3, incorporating the upstream fix.

File-Level Changes

Change Details Files
Upgrade @lobehub/ui to include Firefox Mermaid bugfix
  • Bump @lobehub/ui from ^2.5.6 to ^2.7.3
 package.json

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review setting 8000 s.

Getting Help

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 26, 2025
greptile-apps[bot]
greptile-apps bot reviewed Jun 26, 2025
View reviewed changes
Copy link
Contributor
@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@lobehubbot
Copy link
Member

👍 @kingsword09

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

@gru-agent Gru Agent
Copy link
Contributor
gru-agent bot commented Jun 26, 2025 •
e 8000 dited
Loading

TestGru Assignment

Summary

Link CommitId Status Reason
Detail 8d537e2 🚫 Skipped No files need to be tested {"package.json":"File path does not match include patterns."}

History Assignment

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

@dosubot dosubot bot added the 🐛 Bug Something isn't working | 缺陷 label Jun 26, 2025
@codecov Codecov
Copy link
codecov bot commented Jun 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.37%. Comparing base (176e49a) to head (8d537e2).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8270   +/-   ##
=======================================
  Coverage   87.37%   87.37%           
=======================================
  Files         843      843           
  Lines       62930    62930           
  Branches     3946     3947    +1     
=======================================
  Hits        54983    54983           
  Misses       7947     7947
Flag Coverage Δ
app 87.37% <ø> (ø)
server 95.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arvinxx arvinxx merged commit d9c5e7b into lobehub:main Jun 28, 2025
6 of 8 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @kingsword09 ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献，感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣，请加入我们的 discord，然后私信 @arvinxx 或 @canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发，分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Jun 28, 2025
@semantic-release-bot
🔖 chore(release): v1.96.11 [skip ci]
f5e5465 
### [Version&nbsp;1.96.11](v1.96.10...v1.96.11)
<sup>Released on **2025-06-28**</sup>

#### 🐛 Bug Fixes

- **mermaid**: Firefox mermaid show error.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **mermaid**: Firefox mermaid show error, closes [#8270](#8270) ([d9c5e7b](d9c5e7b))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.96.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kingsword09 kingsword09 deleted the fix-firefox-mermaid branch June 28, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees
No one assigned
Labels
🐛 Bug Something isn't working | 缺陷 released size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firefox浏览器无法点击查看mermaid生成的图
3 participants
@kingsword09 @lobehubbot @arvinxx
0