8000 ❔ Question: ChargingProfile optional fields · Issue #350 · lorenzodonini/ocpp-go · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
❔ Question: ChargingProfile optional fields #350
Open
@Vlsarro

Description

@Vlsarro

❔ What is your question?

Hello, I have a question regarding ChargingProfile struct. In OCPP1.6 spec ChargingProfile.transactionId is an optional field and in the code (https://github.com/lorenzodonini/ocpp-go/blob/master/ocpp1.6/types/types.go#L132) it is marked as omitempty but the field itself is not *int but int. The same applies to ChargingProfile.RecurrencyKind, I think it should be a pointer field too.

The same can be said about ClearChargingProfileRequest (https://github.com/lorenzodonini/ocpp-go/blob/master/ocpp1.6/smartcharging/clear_charging_profile.go#L36), ClearChargingProfileRequest.ChargingProfilePurpose is an optional field according to spec but in the code it is not a pointer and at the same time this field has omitempty tag.

So does it need to be fixed? Or everything is fine as it is?

Which OCPP version referring to?

  • OCPP 1.6
  • OCPP 2.0.1

Are you using any OCPP extensions?

  • OCPP 1.6 Security
  • OCPP 1.6 Plug and Charge

👀 Have you spent some time to check if this question has been asked before?

  • I checked and didn't find a similar issue

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0