8000 why template class Reader ? · Issue #35 · p-ranav/csv2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
why template class Reader ? #35
Open
@reder2000

Description

@reder2000

Recall that :
template <class delimiter = delimiter<','>, class quote_character = quote_character<'"'>,
class first_row_is_header = first_row_is_header,
class trim_policy = trim_policy::trim_whitespace> class Reader

I am not sure about what is the exact benefit of that.
For instance, delimiter is a parameter for Cell only. quote_character as well.
first_row_is_header is used only once in RowIterator begin()
is_trim_char could well be implemented as a std::string+contains(tested char)

I don't think speed would suffer much, and flexibility would be better.

Any opinion ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0