10000 Change max cost to include threshold · Issue #27 · pysal/access · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change max cost to include threshold #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking &ld 8000 quo;Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JamesSaxon opened this issue Apr 3, 2022 · 3 comments
Open

Change max cost to include threshold #27

JamesSaxon opened this issue Apr 3, 2022 · 3 comments

Comments

@JamesSaxon
Copy link
Contributor

This is a change was requested by @knaaptime in the discussion for 26. It is a one-character fix here:

access/access/fca.py

Line 55 in bfae8ed

if max_cost is not None: temp = temp[temp[cost_cost] < max_cost].copy()

But it will also break the expectations of the zero-catchment tests here:

access/access/tests/test_floating_catchment_area.py

Lines 75 to 80 in bfae8ed

def test_floating_catchment_area_ratio_zero_catchment(self):
zero_catchment = 0
result = self.model.fca_ratio(max_cost = zero_catchment)
actual = math.isnan(self.model.access_df.iloc[0]['fca_value'])
self.assertEqual(actual, True)

Not a hard change but your judgment call.
@JamesSaxon
Copy link
Contributor Author

Hey @knaaptime, just following up here. Happy to update the code and tests, but wanted one last confirmation on your side...

@jGaboardi
Copy link
Member

@JamesSaxon Do we want to wait for Eli's response before doing this next release?

@JamesSaxon
Copy link
Contributor Author
JamesSaxon commented May 14, 2022 •
edited
Loading

@jGaboardi, unless it's a ton of work for you, I'd rather just get that piece out.

@JamesSaxon JamesSaxon mentioned this issue May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jGaboardi @JamesSaxon
0