8000 Allow user to easily add a system message to each message · Issue #1328 · pytorch/torchtune · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow user to easily add a system message to each message #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joecummings opened this issue Aug 13, 2024 · 2 comments
Closed

Allow user to easily add a system message to each message #1328

joecummings opened this issue Aug 13, 2024 · 2 comments
Labels
better engineering Tasks which help improve eng productivity e.g. building tools, cleaning up code, writing docs bug Something isn't working

Comments

@joecummings
Copy link
Contributor

Currently user has to create a custom message converter class (yuck) or prepend to the user message, which isn't really correct.
@joecummings joecummings added better engineering Tasks which help improve eng productivity e.g. building tools, cleaning up code, writing docs bug Something isn't working labels Aug 13, 2024
@joecummings
Copy link
Contributor Author

In my mind this is a significant gap. Maybe we do something like:

messsage_transform = [AddSystemMessage("You are the best coding assistant around"), AlpacaToMessages()]

@joecummings joecummings added this to the Demo milestone Aug 14, 2024
@RdoubleA RdoubleA mentioned this issue Aug 19, 2024
Merged
13 tasks
@SalmanMohammadi
Copy link
Collaborator

Addressed by #1366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
better engineering Tasks which help improve eng productivity e.g. building tools, cleaning up code, writing docs bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joecummings @SalmanMohammadi
0