8000 Remove XlaNode::Clone(torch::lazy::OpList operands) · Issue #4567 · pytorch/xla · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove XlaNode::Clone(torch::lazy::OpList operands) #4567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
steventk-g opened this issue Feb 4, 2023 · 2 comments
Open

Remove XlaNode::Clone(torch::lazy::OpList operands) #4567

steventk-g opened this issue Feb 4, 2023 · 2 comments
Assignees
@steventk-g
Labels
tech debt Technical Debt Is Evil

Comments

@steventk-g
Copy link
Collaborator

We only use this API in Uitl::Clone() methods found in https://github.com/pytorch/xla/blob/master/torch_xla/csrc/ir_util.h, which are not used anywhere. So, we can remove this method and replace it with XlaNode::Clone() and forward operands internally.
@JackCaoG
Copy link
Collaborator
JackCaoG commented Feb 4, 2023

Clone method was origionally developed to do some pytorch/xla level node optimization before passing to XLA. We didn;t ended up implementing that that clonet method was not used anywhere.

@steventk-g steventk-g mentioned this issue Feb 4, 2023
Draft
@alanwaketan
Copy link
Collaborator

@steventk-g feel free to re-assign to me.

@ysiraichi ysiraichi added the tech debt Technical Debt Is Evil label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steventk-g steventk-g

Labels
tech debt Technical Debt Is Evil
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ysiraichi @alanwaketan @JackCaoG @steventk-g
0