Fix sun-earth distance correction #107

sfinkens · 2022-07-11T10:12:54Z

Recently a bug in pyorbital's sun-earth distance correction was fixed: pytroll/pyorbital#97.

Pygac does not use pyorbital for this, but makes the same mistake:

Line 89 in 05ba35e

corr = 1.0 - 0.0334 * np.cos(2.0 * np.pi * (jday - 2) / 365.25)

I propose to use pyorbital for this.

@ninahakansson @abhaydd @kgkarl This would change the output (to the better).

mraspaud · 2022-07-11T12:38:33Z

It makes total sense to remove code duplication, I'm in favour.

To make sure the bug doesn't reappear, maybe a test case for reflectance computation could be added at the same time?

sfinkens · 2022-07-11T13:09:01Z

Sorry, false alarm. As pointed out by @abhaydd the factor is applied only once, so there's no problem.

Line 340 in 05ba35e

r_cal *= corr

I'm opening a new issue regarding code duplication.

mraspaud · 2022-07-11T13:18:20Z

@sfinkens, I still think it makes sense to remove code duplication and use pyorbital here.

sfinkens self-assigned this Jul 11, 2022

sfinkens added the bug label Jul 11, 2022

sfinkens closed this as completed Jul 11, 2022

Provide feedback