Method get_tle_lines() raises index error when tle lines are empty strings #94

oliversus · 2021-09-02T16:34:23Z

In pod_reader.py._compute_missing_lonlat(): Function get_tle_lines() will raise an IndexError if the next available tle line is not within a user-defined threshold of n days. Pygac should be able to handle this issue, as tle data are gappy, and a fix has been introduced to deal with such cases. In fact, before a recent commit (3f04306), this error has been caught and tle lines were set to emtpy strings.

One could undo that commit, i.e. put that function back into a try clause like so:

        try:
            tle1, tle2 = self.get_tle_lines()
        except IndexError:
            tle1 = tle2 = ''

This would at least allow pygac to continue.
However, this causes new problems in compute_pixels(), which calls pyorbital, thus initializing class Tle. Tle will be unhappy about tle lines being empty strings and thus raise IndexErrors.

As I do not know the code structure well enough: does it make sense to just quit compute_missing_lonlat when there are no tle data within the threshold? Or apply the tle fix here?

The text was updated successfully, but these errors were encountered:

sfinkens mentioned this issue Sep 9, 2021

Fix clockdrift adjustment in case of missing TLEs #95

Merged

sfinkens self-assigned this Sep 9, 2021

sfinkens added the bug label Sep 9, 2021

sfinkens closed this as completed in #95 Sep 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Method get_tle_lines() raises index error when tle lines are empty strings #94

Method get_tle_lines() raises index error when tle lines are empty strings #94

Method get_tle_lines() raises index error when tle lines are empty strings #94

Method get_tle_lines() raises index error when tle lines are empty strings #94

Comments