8000 Сondition can be split between sections, which breaks the parsing · Issue #365 · packit/specfile · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Сondition can be split between sections, which breaks the parsing #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 tasks
nikitych opened this issue Apr 5, 2024 · 3 comments
Open
2 tasks

Сondition can be split between sections, which breaks the parsing #365

nikitych opened this issue Apr 5, 2024 · 3 comments
Labels
area/general Not tied to a specific area complexity/single-task Regular task; should be done within days gain/high Brings a lot of value to users impact/low Affects only few of the users kind/bug An unexpected problem or behavior

Comments

@nikitych
Copy link
Contributor
nikitych commented Apr 5, 2024

What happened? What is the problem?

In case of pg_auto_failover.spec or xorgxrdp.spec begin of condition remains in main package section while %endif goes to sub-package. So you get IndexError when trying to parse it.

from specfile import Specfile
with Specfile("xorgxrdp.spec") as specfile:
    with specfile.sections() as sections:
        for section in sections:
            if "package" in section.name:
                with specfile.tags(section) as tags:
                    for tag in tags:
                        print(tag.name)

  File "/usr/lib64/python3.9/site-packages/specfile/context_management.py", line 133, in __call__
    self.values[key] = next(self.generators[key])
  File "/usr/lib64/python3.9/site-packages/specfile/specfile.py", line 273, in tags
    tags = Tags.parse(section, context=self)
  File "/usr/lib64/python3.9/site-packages/specfile/tags.py", line 497, in parse
    lines = process_conditions(list(section), macro_definitions, context)
  File "/usr/lib64/python3.9/site-packages/specfile/conditions.py", line 119, in process_conditions
    result.append((line, branches[-2]))
IndexError: list index out of range

What did you expect to happen?

No errors.

May be process conditions before splitting to sections?

Example URL(s)

No response

Steps to reproduce

1. get xorgxrdp.spec
2. try to get package glamor tags
3. IndexError: list index out of range

Workaround

  • There is an existing workaround that can be used until this issue is fixed.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@nforro
Copy link
Member
nforro commented Apr 6, 2024

Thanks for the report. This is basically the same issue as #231, but I didn't realize it affects also parsing. Let me think about how to fix this.

8000 @mfocko mfocko added kind/bug An unexpected problem or behavior area/general Not tied to a specific area complexity/single-task Regular task; should be done within days gain/high Brings a lot of value to users impact/low Affects only few of the users labels Apr 8, 2024
@mfocko mfocko moved this from new to backlog in Packit Kanban Board Apr 8, 2024
@kin4stat
Copy link

@mfocko maybe it's reasonable to move this issue to "priority backlog"?

There are a lot of packages with feature macros inside specfile

i.e

%if %{with dane}
%package dane
Summary: A DANE protocol implementation for GnuTLS
Requires: %{name}%{?_isa} = %{version}-%{release}
%endif

%if %{with guile}
%package guile
Summary: Guile bindings for the GNUTLS library
Requires: %{name}%{?_isa} = %{version}-%{release}
Requires: guile22
%endif

For example python3.9, gnutls and others...

@mfocko
Copy link
Member
mfocko commented Apr 17, 2025

Still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/general Not tied to a specific area complexity/single-task Regular task; should be done within days gain/high Brings a lot of value to users impact/low Affects only few of the users kind/bug An unexpected problem or behavior
Projects
Packit Kanban Board
Status: backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mfocko @nikitych @nforro @kin4stat
0