8000 [ControlGroup] Border radius not inherited by components with popovers · Issue #2730 · palantir/blueprint · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ControlGroup] Border radius not inherited by components with popovers #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
badams opened this issue Jul 26, 2018 · 0 comments
Closed

[ControlGroup] Border radius not inherited by components with popovers #2730

badams opened this issue Jul 26, 2018 · 0 comments
Labels
Package: core Type: bug

Comments

@badams
Copy link
Contributor
badams commented Jul 26, 2018

Environment

  • Package version(s): 3.0.1
  • Browser and OS versions: Chrome 67.0.3396.99 (Official Build) (64-bit)

Steps to reproduce

Add a popover to a button that is inside a control group

 <ControlGroup>
    <Popover content={<p>Hello</p>}>
        <Button text="Open"/>
    </Popover>
    <Button icon="cross"/>
</ControlGroup>

Actual behavior

Border radius is not inherited by components wrapped in a popover, eg <Select />, <Button />

screen shot 2018-07-27 at 10 55 05 am

Expected behavior

Components should inherit border radius based on their position in the ControlGroup

screen shot 2018-07-27 at 10 54 47 am

Possible solution

Add border-radius: inherit to popover-target and popover-wrapper when inside a control group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: core Type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@badams @giladgray
0