Spring enhancements #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added annotation which allows to delay some beans initialization after schema migration is performed
patka
reviewed
May 27, 2019
| .setCreateKeyspace(properties.isCreateKeyspace()); | ||
| } | ||
|
|
||
| @Bean |
There was a problem hiding this comment.
Since you are using the bean in the HealthIndicator you should use it in the migrationTaskChain method as well by having it autowired. Otherwise you end up having two instances of that class. This is not necessarily bad but the idea of Spring is to have beans as Singletons unless explicitly stated otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added health indicator
Added annotation which allows to delay some beans initialization after schema migration is performed
Added ability to disable migration using spring configuration