8000 Flaky TestMediaFile_GetColors_Slow test · Issue #105 · photoprism/photoprism · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Flaky TestMediaFile_GetColors_Slow test #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
skunert opened this issue Apr 20, 2019 · 4 comments
Closed

Flaky TestMediaFile_GetColors_Slow test #105

skunert opened this issue Apr 20, 2019 · 4 comments
Assignees
@skunert
Labels
declined Cannot be merged or implemented at this time

Comments

@skunert
Copy link
Contributor
skunert commented Apr 20, 2019

Sadly, TestMediaFile_GetColors_Slow is now flaky because of PR #103. The output of the prominentcolors library depends on some random parameters in the algorithm.
I think we should move the discussion here instead of the PR.
@skunert
Copy link
Contributor Author
skunert commented Apr 20, 2019 •
edited
Loading

I have ideas how to fix the issue, but do not have time until monday. Will get to it then.

@lastzero
Copy link
Member

I've just pushed an implementation that doesn't use random numbers. It also enables us to search specific parts of an image (3x3 pixels = up to 9 colors). Seems to work well for now! A friend of mine did that long ago for an art project, not sure if it's an official algorithm 😉

Of course you can have the bounty for #7 if you like, see https://issuehunt.io/r/photoprism/photoprism/issues/7

Screenshot 2019-04-26 at 02 30 23

@lastzero lastzero added the declined Cannot be merged or implemented at this time label Apr 26, 2019
@skunert
Copy link
Contributor Author
skunert commented Apr 26, 2019

Okay, I was too slow :D. But nice that you fixed it so quickly, sorry for the hassle.

@lastzero
Copy link
Member

It was really helpful that you pushed this forward 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skunert skunert

Labels
declined Cannot be merged or implemented at this time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lastzero @skunert
0