8000 Add phpunit 12.0 support · Issue #24 · phpacker/phpacker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add phpunit 12.0 support #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SerafimArts opened this issue Mar 24, 2025 · 3 comments
Closed

Add phpunit 12.0 support #24

SerafimArts opened this issue Mar 24, 2025 · 3 comments
Labels
good first issue Good for newcomers

Comments

@SerafimArts
Copy link

When installing according to the instructions

composer require phpacker/phpacker --dev

The following errors occur as a dependency:

- Root composer.json requires phpacker/phpacker * -> satisfiable by phpacker/phpacker[dev-feature/execution-context-detection, dev-fix/custom-bin-repo-path, dev-feat-gitattributes, dev-chore/update-php-bin, dev-fix-bin-path, dev-main, 0.1, ..., 0.3.4, 9999999-dev].
    - phpunit/phpunit is locked to version 12.0.10 and an update of this package was not requested.
    - nunomaduro/collision[v8.6.0, ..., v8.x-dev] conflict with phpunit/phpunit <11.5.3 || >=12.0.0.
    - phpacker/phpacker[dev-feature/execution-context-detection, dev-fix/custom-bin-repo-path, dev-feat-gitattributes, dev-chore/update-php-bin, dev-fix-bin-path, dev-main, 0.1, ..., 0.3.4] require nunomaduro/collision ^8.6 -> satisfiable by nunomaduro/collision[v8.6.0, v8.6.1, v8.7.0, v8.x-dev]

It seems that the dependency on nunomaduro/collision contains conflict with actual phpunit 12.0 (see https://packagist.org/packages/nunomaduro/collision#v8.7.0)

I suggest moving the nunomaduro/collision dependency to the "require-dev" section and adding it to the "suggest" and making it optional
@gwleuverink
Copy link
Contributor

Hey @SerafimArts. Thanks for reporting this.

Because we are distributing self contained executables we actually do not need to check any version constraints.
I contemplated moving everything to require-dev but this came with a big drawback; the executable size grew significantly.

I'm currently working on a better way to approach this. Hope to nail something down soon.

@gwleuverink
Copy link
Contributor< A19C /span>

In the meantime your suggestion sounds good. I don't think we need to use collision in the builds.

@gwleuverink gwleuverink added the good first issue Good for newcomers label Mar 24, 2025
@gwleuverink gwleuverink mentioned this issue Apr 2, 2025
Merged
@gwleuverink
Copy link
Contributor

I've moved collision to the dev dependencies in v0.3.5 pending a better solution using the custom installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SerafimArts @gwleuverink
0