10000 Small bug with double "$" before variables and documentation inside menu · Issue #31 · phpactor/coc-phpactor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Small bug with double "$" before variables and documentation inside menu #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lukepass opened this issue Jul 25, 2022 · 5 comments
Open

Small bug with double "$" before variables and documentation inside menu #31

lukepass opened this issue Jul 25, 2022 · 5 comments

Comments

@lukepass
Copy link

Hello!
I think there are 2 small problems after the last update (maybe related to phpactor/phpactor#1775).

  • When completing the variable name a new "$" is added to the variable (please note the double "$" before $myCollection)
  • The completion menu contains the documentation and so it becomes quite difficult to read (at the end of the video you can se the first and other methods completion

I made a GIF to explain both problems:

Peek 2022-07-25 17-47

Thanks again.
@dantleech
Copy link
Contributor

hm, strange.

for the first see https://phpactor.readthedocs.io/en/master/lsp/vim.html#two-dollars-on-variables although that would not have been caused by that PR - and AFAIK I don't need this in my config.

For the second ... that looks very odd -- are you sure it's not custom config on your end?

@dantleech
Copy link
Contributor
dantleech commented Jul 25, 2022 •
edited
Loading

testing with CoC - I get neither the $$ or the other issue:

image

But I also don't the documentation either, so maybe it is a config issue?

@lukepass
Copy link
Author

Hello! The first problem was solved by following your guide on phpactor:

autocmd FileType php set iskeyword+=$

The second one seems a problem only with GVim or Neovim-qt (so the GUIs), it doesn't show up using the terminal.

@dantleech
Copy link
Contributor

hm, does it happen also with other language servers?

@lukepass
Copy link
Author

As far as I can tell only for phpactor: JS is fine, CSS is fine, HTML is fine and PHP when using yaegassy/coc-intelephense is fine.
Please tell me if I can be of any help!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dantleech @lukepass
0