Resolve undeclared SSRC using the payload type #3066
Conversation
4483205 to
c2c70bf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3066 +/- ##
==========================================
+ Coverage 78.59% 78.79% +0.19%
==========================================
Files 91 91
Lines 11313 11331 +18
==========================================
+ Hits 8892 8928 +36
+ Misses 1934 1919 -15
+ Partials 487 484 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // (urn:ietf:params:rtp-hdrext:sdes:rtp-stream-id and urn:ietf:params:rtp-hdrext:sdes:mid) | ||
| // and even if the RTP stream contains an incorrect MID or RID. | ||
| // while this can be incorrect, this is done to maintain compatibility with older behavior. | ||
| if len(remoteDescription.parsed.MediaDescriptions) == 1 { |
There was a problem hiding this comment.
Totally optional: do we want to wrap this into a settings flag, which is on by default for now, so that we can switch the setting off in a later release to initiate deprecation of this "feature"?
There was a problem hiding this comment.
Yeah, we should do this too, I will make an issue for the stuff we should deprecate and will address them separately (i have a private list). Thank you!
c112428 to
e252abd
Compare
|
Thank you so much @nils-ohlmeier for your thorough review. I truly appreciate it! |
Introduces a fallback mechanism to handle undeclared SSRCs from multiple sections using the RTP stream's payload type. For legacy clients without MID extension support, it documents the existing behavior for handling undeclared SSRCs in single media sections.
e252abd to
5ce8e05
Compare
Not great to move back, but it is affecting some clients. Use an older version till there is better determination as to why. It also pulls back webrtc a version which has this one interesting change pion/webrtc#3066, but that is not critical.
Description
Introduces a fallback mechanism to handle undeclared SSRCs from multiple sections using the RTP stream's payload type. For legacy clients without MID extension support, it documents the existing behavior for handling undeclared SSRCs in single media sections.
This matches the behavior with chrome and Firefox. https://chromium.googlesource.com/external/webrtc/+/refs/heads/master/call/rtp_demuxer.cc#372
Reference issue
resolves #3065