Error: Unable to update lock within the stale threshold #594

aecz · 2017-02-01T11:17:45Z

Code to reproduce

pnpm install

Actual behavior:

pnpm starts to install packages in node_modules/.resolutions then fails with only 300 of them installed (1000 to be installed). node.exe process memory goes up to 800MB and exits with the following error.
Running the command again installs a few more packages each time (around 5). Please note that i have 11GB RAM free before running the command :)

C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:180
    compromised = compromised || function (err) { throw err; };
                                                  ^
Error: Unable to update lock within the stale threshold
    at options.fs.utimes (C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:108:66)
    at FSReqWrap.oncomplete (fs.js:123:15)

Additional information:

pnpm-debug.log.txt

pnpm 0.50.0
node 6.9.4
Windows 7

The text was updated successfully, but these errors were encountered:

aecz · 2017-02-01T11:22:38Z

Just found this explanation on the proper-lockfile repo.
moxystudio/node-proper-lockfile#11
Looks like we need to set a bigger delay or at least add an option for it.

aecz · 2017-02-03T12:25:28Z

Error still happening unfortunately even after using next version 0.52.0.
You can get the package.json on the linked PR.

Here is some more info of my last test:

1st run: 700 packages installed, max memory used (didnt check the first run :( )

C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:180
    compromised = compromised || function (err) { throw err; };
                                                  ^
Error: Unable to update lock within the stale threshold
    at options.fs.utimes (C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:108:66)
    at FSReqWrap.oncomplete (fs.js:123:15)

2st run: 14 more packages installed, max memory used 500 MB

C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:180
    compromised = compromised || function (err) { throw err; };
                                                  ^
Error: Unable to update lock within the stale threshold
    at options.fs.utimes (C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:108:66)
    at FSReqWrap.oncomplete (fs.js:123:15)

3st run: 70 more packages installed, max memory used 620 MB

ERROR unexpected end of file
Error: unexpected end of file
    at Zlib._handle.onerror (zlib.js:370:17)
Error: unexpected end of file
    at Zlib._handle.onerror (zlib.js:370:17)
Error: unexpected end of file
    at Zlib._handle.onerror (zlib.js:370:17)
Error: unexpected end of file
    at Zlib._handle.onerror (zlib.js:370:17)

4th run: 237 more packages installed, max memory used 710 MB

Error: unexpected end of file
    at Zlib._handle.onerror (zlib.js:370:17)
Error: unexpected end of file
    at Zlib._handle.onerror (zlib.js:370:17)
Error: unexpected end of file
    at Zlib._handle.onerror (zlib.js:370:17)
Error: unexpected end of file
    at Zlib._handle.onerror (zlib.js:370:17)

5th run: 29 more packages installed, max memory used 730MB

WARN Skipping failed optional dependency gulp-xslt@2.0.0
ERROR unexpected end of file
Error: unexpected end of file
    at Zlib._handle.onerror (zlib.js:370:17)
Error: unexpected end of file
    at Zlib._handle.onerror (zlib.js:370:17)
Error: unexpected end of file
    at Zlib._handle.onerror (zlib.js:370:17)
Error: unexpected end of file
    at Zlib._handle.onerror (zlib.js:370:17)

6th run: 15 more packages installed, max memory used 642MB

C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:180
    compromised = compromised || function (err) { throw err; };
                                                  ^
Error: Unable to update lock within the stale threshold
    at options.fs.utimes (C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:108:66)
    at FSReqWrap.oncomplete (fs.js:123:15)

7th run: 16 more packages installed, max memory used 628MB

C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:180
    compromised = compromised || function (err) { throw err; };
                                                  ^
Error: Unable to update lock within the stale threshold
    at options.fs.utimes (C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:108:66)
    at FSReqWrap.oncomplete (fs.js:123:15)

8th run: 3 more packages installed (stopped measuring memory, doesnt seem an issue)
(core-js then karma then webdriverio)

C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:180
    compromised = compromised || function (err) { throw err; };
                                                  ^
Error: Unable to update lock within the stale threshold
    at options.fs.utimes (C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:108:66)
    at FSReqWrap.oncomplete (fs.js:123:15)

9th run: 1 more packages installed (pm2)

C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:180
    compromised = compromised || function (err) { throw err; };
                                                  ^
Error: Unable to update lock within the stale threshold
    at options.fs.utimes (C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:108:66)
    at FSReqWrap.oncomplete (fs.js:123:15)

10th run: 2 more packages installed (rxjs, ng2-google-place-autocomplete)

C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:180
    compromised = compromised || function (err) { throw err; };
                                                  ^
Error: Unable to update lock within the stale threshold
    at options.fs.utimes (C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:108:66)
    at FSReqWrap.oncomplete (fs.js:123:15)

11th run: 2 more packages installed (rxjs, ng2-google-place-autocomplete)

C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:180
    compromised = compromised || function (err) { throw err; };
                                                  ^
Error: Unable to update lock within the stale threshold
    at options.fs.utimes (C:\Users\aecz\AppData\Roaming\nvm\v6.9.4\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:108:66)
    at FSReqWrap.oncomplete (fs.js:123:15)

12th run: 3 more packages installed (libxmljs-mt, libxslt, gulp-xslt)
=> No errors and binaries compiled successfully!

So it looks like only some packages are problematic. Once installed, no issues so far.
Another issue has appeared maybe unrelated about zlib.

zkochan · 2017-02-03T16:50:37Z

I think the solution for #600 will solve your issues as well

Rel #600, Rel #594

zkochan · 2017-02-05T00:20:10Z

I believe this is fixed in 0.52.1. I cannot reproduce this anymore

akomakom · 2017-02-06T15:58:35Z

Still seeing this (intermittently) with 0.52.1. Had to put a retry loop around it.

00:00:29.814 + pnpm install
00:00:56.492 /node4/lib/node_modules/pnpm/lib/node_modules/proper-lockfile/index.js:180
00:00:56.492 compromised = compromised || function (err) { throw err; };
00:00:56.492 ^
00:00:56.492
00:00:56.492 Error: Unable to update lock within the stale threshold
00:00:56.492 at /node4/lib/node_modules/pnpm/lib/node_modules/proper-lockfile/index.js:108:66
00:00:56.492 at FSReqWrap.oncomplete (fs.js:82:15)
00:00:56.493
00:00:56.523 ERROR: script returned exit code 1
00:00:56.523 Retrying
00:00:56.601 Running shell script
00:00:56.870 + pnpm install

(worked the second time)

zkochan · 2017-02-06T19:43:55Z

As a temporary fix, we can

make the timeout configurable
add a --no-lock option

ref #608, ref #594

vjpr · 2017-05-03T10:21:24Z

I'm still seeing this error in 0.66.2 on Ubuntu 16.04.

--lock-stale-duration=0 seems to prevent it.

I think instructions to enable this flag should printed when this error occurs. But it would be better to try avoid it...

vjpr · 2017-05-03T10:30:26Z

Seeing it on macOS Sierra too.

zkochan · 2017-05-07T10:11:05Z

OK, let me add a --no-lock option for now, and then we'll try to solve it better.

Plus an error message as you suggested

Ref #594

zkochan · 2017-05-07T20:42:26Z

--no-lock released with v0.67.0

louy2 · 2017-06-11T07:51:04Z

I am also experiencing this when installing truffle and ethereumjs-testrpc on Alpine Linux during linking.

HarshulSharma000 · 2018-02-09T11:58:02Z

Still not able to lock within stale threshold. On setting the --no-lock flag it works shouldn't the default timeout increased further?
OS: Windows 10
Node: 9.4.0
Yarn: 1.4.0
npm: 4.6.1
Watchman: 4.9.1

msssk · 2018-03-01T07:00:57Z

I'm seeing this with 1.35.1 (Windows 10, Node 8.9.0)

D:\dev\src\abc>pnpm i
Resolving: total 766, reused 0, downloaded 0
D:\dev\nodejs\pnpm-global\1\node_modules\.registry.npmjs.org\pnpm\1.35.1\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:186
    compromised = compromised || function (err) { throw err; };
                                                  ^

Error: Unable to update lock within the stale threshold
    at options.fs.utimes (D:\dev\nodejs\pnpm-global\1\node_modules\.registry.npmjs.org\pnpm\1.35.1\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:108:66)
    at FSReqWrap.oncomplete (fs.js:135:15)

vjpr · 2018-03-01T09:36:08Z

I also saw this recently in Ubuntu 14.

…

On Thu 1. Mar 2018 at 08:00, Mangala Sadhu Sangeet Singh Khalsa < ***@***.***> wrote: I'm seeing this with 1.35.1 (Windows 10, Node 8.9.0) D:\dev\src\abc>pnpm i Resolving: total 766, reused 0, downloaded 0 D:\dev\nodejs\pnpm-global\1\node_modules\.registry.npmjs.org\pnpm\1.35.1\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:186 compromised = compromised || function (err) { throw err; }; ^ Error: Unable to update lock within the stale threshold at options.fs.utimes (D:\dev\nodejs\pnpm-global\1\node_modules\.registry.npmjs.org\pnpm\1.35.1\node_modules\pnpm\lib\node_modules\proper-lockfile\index.js:108:66) at FSReqWrap.oncomplete (fs.js:135:15) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#594 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARLRREZ9lcyyx1U2MioS19MgbVvrNHmks5tZ5yrgaJpZM4Lzv2y> .

imeredith · 2018-04-04T21:28:12Z

I'm having this issue on macOS with node 6.8.1 and 8.9.4.

zkochan · 2018-04-09T12:28:07Z

To my knowledge, all operations that are done by pnpm, are done atomically, so it should be safe to run pnpm without locks.

I suggest to turn off locks by default.

ref pnpm/pnpm#594

octogonz · 2018-04-28T23:05:24Z

@nickpape-msft sounds great, maybe you could move that logic to a separate package and then we'll be able to substitute proper-lockfile in @pnpm/fs-locker

(FWIW we generally avoid creating tiny NodeJS packages with only 300 lines of code in them. It's bad for performance. Also, the more individual dependencies you have, the harder it is to avoid side-by-side versions.)

weichensw · 2020-04-28T15:43:43Z

This still happens quite frequently in my CI pipelines with pnpm version 4.14, on Windows 10 and Windows Server machines.

zkochan · 2020-04-28T16:07:25Z

OK, let's remove the lock in v5 Wei Chen <notifications@github.com> ezt írta (időpont: 2020. ápr. 28., K 18:44):

…

This still happens quite frequently in my CI pipelines with pnpm version 4.14, on Windows 10 and Windows Server machines. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#594 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOWTGYE3YFWARYRX4INOYDRO32T7ANCNFSM4C6O7WZA> .

PR #2542 ref #594

close #594

zkochan · 2020-05-13T21:45:53Z

I created a PR to remove locking #2553

close #594 PR #2553

aecz mentioned this issue Feb 1, 2017

Increased stale duration from 10s to 20s #595

Closed

zkochan self-assigned this Feb 3, 2017

zkochan added a commit that referenced this issue Feb 3, 2017

fix(fetch): limit simultaneous fetches

32965be

Rel #600, Rel #594

zkochan mentioned this issue Feb 3, 2017

fix(fetch): limit simultaneous fetches #602

Merged

zkochan added a commit that referenced this issue Feb 3, 2017

fix(fetch): limit simultaneous fetches

7e7ef52

Rel #600, Rel #594

zkochan added the state: might be fixed label Feb 4, 2017

zkochan added type: bug and removed state: might be fixed labels Feb 6, 2017

zkochan mentioned this issue Feb 7, 2017

Windows: Unable to update lock within the stale threshold #608

Closed

zkochan added a commit that referenced this issue Feb 7, 2017

feat: add lockStaleDuration config

e7f5346

ref #608, ref #594

zkochan added a commit that referenced this issue Feb 7, 2017

feat: add lockStaleDuration config

4138294

ref #608, ref #594

zkochan mentioned this issue Feb 7, 2017

feat: add lockStaleDuration config #611

Merged

zkochan added the state: has PR label Feb 7, 2017

zkochan added a commit that referenced this issue Feb 8, 2017

feat: add lockStaleDuration config

665c181

ref #608, ref #594

zkochan removed the state: has PR label Mar 11, 2017

zkochan added a commit that referenced this issue May 7, 2017

feat: add a --no-lock option

a059ccf

Ref #594

zkochan added a commit that referenced this issue May 7, 2017

feat: add a --no-lock option

3a2683c

Ref #594

zkochan mentioned this issue May 7, 2017

feat: add a --no-lock option #754

Merged

zkochan added the known issues label May 14, 2017

zkochan added this to the v2.0.0 milestone Feb 21, 2018

zkochan added the help wanted label Apr 4, 2018

zkochan added a commit to pnpm/supi that referenced this issue Apr 14, 2018

fix: set default lockStaleDuration to 5 minutes

69c1b62

ref pnpm/pnpm#594

zkochan mentioned this issue Apr 23, 2018

--warnings-as-errors #1126

Closed

zkochan modified the milestones: v2.0.0, v3.0.0 May 19, 2018

zkochan removed this from the v3.0.0 milestone Dec 14, 2018

zkochan added this to the v5.0 milestone Apr 28, 2020

zkochan added type: breaking change and removed Hacktoberfest help wanted known issues labels Apr 28, 2020

zkochan mentioned this issue May 9, 2020

feat!: remove store state #2542

Merged

zkochan added a commit that referenced this issue May 10, 2020

feat!: remove store state

da091c7

PR #2542 ref #594

zkochan added a commit that referenced this issue May 13, 2020

feat!: remove locking of node_modules

f644beb

close #594

zkochan added a commit that referenced this issue May 13, 2020

feat!: remove locking of node_modules

395d898

close #594

zkochan mentioned this issue May 13, 2020

feat!: remove locking of node_modules #2553

Merged

zkochan closed this as completed in #2553 May 14, 2020

zkochan added a commit that referenced this issue May 14, 2020

feat!: remove locking of node_modules

45fdcfd

close #594 PR #2553

probert94 mentioned this issue Aug 25, 2020

Enable using user PNPM version outside of Vaadin range vaadin/flow#8889

Closed

coderabbitai bot mentioned this issue Feb 11, 2025

一時ディレクトリが別デバイスの場合に設定ファイルの保存がエラーになる問題の修正 sunfish-shogi/shogihome#1104

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Error: Unable to update lock within the stale threshold #594

Error: Unable to update lock within the stale threshold #594

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Error: Unable to update lock within the stale threshold #594

Error: Unable to update lock within the stale threshold #594

Comments

Uh oh!

Code to reproduce

Actual behavior:

Additional information:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!