10000 Incorrect ideal staking rate on Kusama and Polkadot · Issue #9612 · polkadot-js/apps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Incorrect ideal staking rate on Kusama and Polkadot #9612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 4 tasks
jonasW3F opened this issue Jun 20, 2023 · 4 comments
Closed
1 of 4 tasks

Incorrect ideal staking rate on Kusama and Polkadot #9612

jonasW3F opened this issue Jun 20, 2023 · 4 comments
Labels
duplicate

Comments

@jonasW3F
Copy link

  • I'm submitting a ...

    • Bug report
    • Feature request
    • Support request
    • Other

  • What is the current behavior and expected behavior?

The ideal staking rate is shown as 75% on Polkadot and 45% on Kusama. Both values are incorrect. The ideal staking rate is calculated here by using all active parachains with an ID greater or equal than 2000 (i.e., no system parachains).

It seems to me the Polkadot tab does not at all calculate the proper ideal staking rate, while the Kusama tab might still use the (outdated) calculation of using the number of auctions (that keeps counting up even if slots expire), pushing it to the minimum of 45%

Based on my calculations the ideal staking rate right now should be 53.5% on Polkadot (43 parachains) and 55% on Kusama (40 parachains).
@jacogr
Copy link
Member
jacogr commented Jun 20, 2023 •
edited
Loading

Duplicate of #8174 (Early PR for the functionality #8400)

@jacogr jacogr marked this as a duplicate of #8174 Jun 20, 2023
@jacogr jacogr closed this as completed Jun 20, 2023
@jonasW3F
Copy link
Author

ah, sorry for that and thanks for fixing it.

@jacogr
Copy link
Member
jacogr commented Jun 20, 2023

It is not "fixed" - it will probably still be while until I get some time to add tests to the Rust codebase to compare and then check/merge the linked PR. Unless there is proven consistency between the 2, cannot merge it.

(This is what was done on the initial implementation of the subsequently changed inflation calcs - port logic, add tests to compare between Rust/JS, compare, tweak, merge)

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jacogr @jonasW3F @polkadot-js-bot
0