8000 Menus bounded by application window · Issue #258 · pop-os/libcosmic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Menus bounded by application windo 8000 w #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jackpot51 opened this issue Jan 7, 2024 · 4 comments
Open

Menus bounded by application window #258

jackpot51 opened this issue Jan 7, 2024 · 4 comments
Milestone
beta

Comments

@jackpot51
Copy link
Member

Since these menus are drawn inside the application window, they cannot go beyond it. I've minimized the issues as much as possible (for example, with #257), but small window sizes still cut off menu content.

Ideally, we'd have a platform agnostic mechanism to make these their own windows. For wayland, these are called popups https://wayland-book.com/xdg-shell-in-depth/popups.html. There is an implementation of menus for Linux, macOS, and Windows here: https://github.com/tauri-apps/muda, but it uses GTK on Linux.
@WatchMkr
Copy link
Contributor
WatchMkr commented Apr 8, 2024

We'll need menus to be bound by the application window for COSMIC apps to work well on small displays such as mobile devices. This needs design work but here are a few techniques we can use:

  1. Remove shortcuts when the width is too narrow
  2. Add scrolling when the length is too short
  3. Adjust the menu opening position so it will be within the window (rather than always on the left or right of the menu label)
  4. Open submenus inside the current menu with a back button at the top

@WatchMkr WatchMkr moved this to Alpha 2 in COSMIC Epoch 1 Apr 8, 2024
@WatchMkr WatchMkr added this to the alpha 2 milestone May 3, 2024
@WatchMkr WatchMkr mentioned this issue May 20, 2024
Closed
@WatchMkr
Copy link
Contributor

Should be completed with the Collapse the Menu design.

@WatchMkr
Copy link
Contributor

Conclusion from alpha 1 summit discussions:

  1. Fork winit to support menus outside of window bounds for alpha 1
  2. For Epoch 2, consider implementing single-column for small screens and as a fallback if we detect a platform where our winit-fork can't properly do popups.

@WatchMkr WatchMkr removed this from the alpha 2 milestone Aug 23, 2024
@git-f0x git-f0x mentioned this issue Oct 21, 2024
Closed
@pop-os pop-os deleted a comment from maria-komarova Dec 23, 2024
@WatchMkr WatchMkr added this to the alpha 6 milestone Jan 15, 2025
@WatchMkr WatchMkr moved this to Alpha 5 in COSMIC Epoch 1 Jan 15, 2025
@WatchMkr WatchMkr mentioned this issue Jan 15, 2025
Closed
@git-f0x git-f0x mentioned this issue Mar 11, 2025
Closed
@iamkartiknayak iamkartiknayak marked this as a duplicate of pop-os/cosmic-files#870 Mar 11, 2025
@WatchMkr WatchMkr moved this from Alpha 7 to Beta in COSMIC Epoch 1 Apr 11, 2025
@WatchMkr WatchMkr modified the milestones: alpha 6, beta Apr 11, 2025
@git-f0x git-f0x mentioned this issue Apr 20, 2025
Closed
@WatchMkr
Copy link
Contributor

Once this feature is added, we'll want to increase the size of the initial menubar items (File, Edit, View, Sort). They're cut-off in some languages.

pop-os/cosmic-term#474
pop-os/cosmic-files#949

This was referenced Apr 28, 2025
Closed
Open
@WatchMkr WatchMkr marked this as a duplicate of pop-os/cosmic-edit#296 May 9, 2025
@WatchMkr WatchMkr marked this as a duplicate of pop-os/cosmic-edit#345 May 14, 2025
@WatchMkr WatchMkr marked this as a duplicate of pop-os/cosmic-term#474 May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
COSMIC Epoch 1
Status: Beta
Milestone
beta
Development

No branches or pull requests
3 participants
@WatchMkr @jackpot51 @maria-komarova
0