Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 4 commits
- 6 files changed
- 1 contributor
Commits on Jan 12, 2025
-
Don't try to use nonexistent libpng optimizations
The embedded copy of libpng doesn't contain code for processor-specific hardware optimizations, but it may still try to use them in some cases, resulting in linker errors. juce_PNGLoader.cpp already sets `PNG_ARM_NEON_OPT` to 0 to disable optimizations on ARM, but this should be done for all architectures, especially PowerPC, where builds currently fail. On x86, this isn't strictly necessary, because libpng optimizations are opt-in for x86, rather than opt-out as with all other architectures, but for completeness and robustness it is also included here. The macros to disable optimizations on other platforms come straight from libpng's own build files; this is how it disables optimizations when compiled without support for them. `PNG_ARM_NEON_OPT` is already one of those macros; this commit simply adds the other three.
-
Add fallback SIMD implementation
This will be used on platforms that don't have native SIMD support.
-
Fix architecture detection on ppc64le
juce_runtime_arch_detection.cpp currently identifies ppc64le as ppc64, which causes it to use the directory name `ppc64-linux` for VST 3 plugin contents. However, VST 3 specifies that `uname -m` should be used as the first component of the directory name, which on 64-bit little-endian PowerPC is `ppc64le`. Currently, this causes problems building VST 3 plugins on this platform, as the VST 3 SDK expects the module directory to be named `ppc64le-linux`. This commit adds an additional endianness check when 64-bit PowerPC is detected, outputting `ppc64` or `ppc64le` as appropriate.
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff surge_8.0.4...surge_8.0.4